Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow condenser to run against different chains #1563

Merged
merged 5 commits into from Jul 26, 2017

Conversation

@jnordberg
Copy link
Contributor

@jnordberg jnordberg commented Jul 14, 2017

This patch adds config options for setting a custom chain id and address prefix. I also had to update the browser tests for it to run.

jnordberg added 3 commits Jul 14, 2017
Needed for condenser to fully work with testnet
A similar memo encryption tests are run somewhere in steem-js when memo.encode is called causing this to throw even if that wasn't the intention.
Copy link
Contributor

@sneak sneak left a comment

minor refactor request

Loading

app/Main.js Outdated
@@ -26,6 +26,12 @@ function runApp(initial_state) {
console.log('Initial state', initial_state);
const config = initial_state.offchain.config
steem.config.set('websocket', config.ws_connection_client);
if (config.custom_addr_prefix) {
steem.config.set('address_prefix', config.custom_addr_prefix);
Copy link
Contributor

@sneak sneak Jul 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would recommend setting address_prefix to STM in defaults.json, and dropping this logic and the use of the custom_ prefixes. Then to use a 'custom' one you just change address_prefix from the default of STM by setting the environment variable to something else.

Loading

@jnordberg
Copy link
Contributor Author

@jnordberg jnordberg commented Jul 22, 2017

Done

Loading

@roadscape
Copy link
Contributor

@roadscape roadscape commented Jul 25, 2017

Why remove the memo encryption test?

Loading

@jnordberg
Copy link
Contributor Author

@jnordberg jnordberg commented Jul 25, 2017

@roadscape When the memo test runs a very similar test was run internally in steem-js, with a hardcoded STM prefix causing the test case to fail.

As I understood the code, the intention of the test was just to check availability of memo encryption, not throw and stop people from logging in. But since the internal steem-js test runs and throws failing the test case it defeated that purpose, so I figured it was better to remove since it never worked in the first place

Loading

@roadscape
Copy link
Contributor

@roadscape roadscape commented Jul 25, 2017

@valzav is it safe to remove this test? I'm not sure of the status of memo encryption myself.

Loading

@valzav
Copy link
Contributor

@valzav valzav commented Jul 26, 2017

@roadscape, I think it's safe to remove memo encryption test - memo encryption is not used in condenser anyway

Loading

@roadscape roadscape merged commit 9e690cf into steemit:master Jul 26, 2017
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants