Allow condenser to run against different chains #1563
Conversation
Needed for condenser to fully work with testnet
A similar memo encryption tests are run somewhere in steem-js when memo.encode is called causing this to throw even if that wasn't the intention.
app/Main.js
Outdated
| @@ -26,6 +26,12 @@ function runApp(initial_state) { | |||
| console.log('Initial state', initial_state); | |||
| const config = initial_state.offchain.config | |||
| steem.config.set('websocket', config.ws_connection_client); | |||
| if (config.custom_addr_prefix) { | |||
| steem.config.set('address_prefix', config.custom_addr_prefix); | |||
There was a problem hiding this comment.
i would recommend setting address_prefix to STM in defaults.json, and dropping this logic and the use of the custom_ prefixes. Then to use a 'custom' one you just change address_prefix from the default of STM by setting the environment variable to something else.
|
Done |
|
Why remove the memo encryption test? |
|
@roadscape When the memo test runs a very similar test was run internally in steem-js, with a hardcoded As I understood the code, the intention of the test was just to check availability of memo encryption, not throw and stop people from logging in. But since the internal steem-js test runs and throws failing the test case it defeated that purpose, so I figured it was better to remove since it never worked in the first place |
|
@valzav is it safe to remove this test? I'm not sure of the status of memo encryption myself. |
|
@roadscape, I think it's safe to remove memo encryption test - memo encryption is not used in condenser anyway |
This patch adds config options for setting a custom chain id and address prefix. I also had to update the browser tests for it to run.