New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppBase v0.19.4rc1 - block_api missing from fullnode.config.ini #2323

Closed
TimCliff opened this Issue Apr 10, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@TimCliff
Copy link
Contributor

TimCliff commented Apr 10, 2018

When creating a "full node" using the example given in https://github.com/steemit/steem/blob/v0.19.4rc1/contrib/fullnode.config.ini, I enabled the following plugins:

plugin = webserver p2p json_rpc witness account_by_key tags follow market_history account_history
plugin = database_api account_by_key_api network_broadcast_api tags_api follow_api market_history_api witness_api condenser_api account_history_api

When I query for:

--data '{"jsonrpc":"2.0","id":0,"method":"jsonrpc.get_methods", "params":{}}'

It is missing these two methods:

block_api.get_block
block_api.get_block_header

Is there a plugin missing from the example config?

@r351574nc3

This comment has been minimized.

Copy link

r351574nc3 commented Apr 11, 2018

I noticed this parameter on steemd

  --disable-get-block                   Disable get_block API call

Seems pretty dubious. Perhaps it's there for when the condenser_api is using get_block

When there are missing elements to the fullnode.config.ini or options I want to change, I use STEEMD_EXTRA_OPTS

STEEMD_EXTRA_OPTS="--plugin block_api"

or

STEEMD_EXTRA_OPTS="--disable-get-block"

Doesn't solve missing plugins from fullnode.config.ini, but it'll answer your questions and maybe gather more data for the problem.

TimCliff added a commit to TimCliff/steem that referenced this issue May 14, 2018

mvandeberg added a commit that referenced this issue May 21, 2018

Merge pull request #2449 from TimCliff/patch-6
Closes #2323 add block_api to fullnode.config
@theoreticalbts

This comment has been minimized.

Copy link
Contributor

theoreticalbts commented May 29, 2018

So here's the situation:

  • The --disable-get-block option disables the get_block call in condenser_api
  • The block_api.* calls are enabled by adding the block_api plugin either via plugin = block_api in the config file, or on the command line via --plugin=block_api
  • When using the Dockerfile, code here adds the block_api plugin to the command line with --plugin=block_api unless the DISABLE_BLOCK_API flag is set.

mvandeberg added a commit that referenced this issue Jun 4, 2018

Merge pull request #2481 from steemit/2449-PR
Closes #2323 add block_api to fullnode.config

@mvandeberg mvandeberg closed this Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment