Bandwidth should be completely removed from code #3029

Activity

1. mvandeberg commented on Oct 3, 2018

   

   mvandeberg

   on Oct 3, 2018

   Contributor

   More actions

   We agree completely. We made the decision to comment it out right now to get it done quickly with the plan to remove it later. Removing it requires a more delicate hand as APIs and other code rely on the bandwidth objects. The current version simply disables the calculations without handling the dependencies in the code that will take more time to remove.
2. mvandeberg

   added

   project/maintenance

   on Oct 3, 2018
3. bobinson commented on Oct 3, 2018

   

   bobinson

   on Oct 3, 2018

   More actions

   Thank you @mvandeberg on your inputs.

   We made the decision to comment it out right now to get it done quickly with the plan to remove it later.

   Just to understand,

   1. are we planning to do a new version without completely removing the bandwidth code ?
   2. do we plan to test it extensively on the TESNET and make sure that all the side effects of removing the bandwidth code is identified and then, do a release ?
4. marvin-bitterlich commented on Oct 8, 2018

   

   marvin-bitterlich

   on Oct 8, 2018

   More actions

   I'm working on a patch for this. Almost ready, but I am writing tests to make sure nothing is breaking.

   Branch: https://github.com/SteemCommunity/steem/tree/feature/remove-bandwith-completely

   👍React with 👍1Reacted by Bobinson K B
5. marvin-bitterlich commented on Oct 8, 2018

   

   marvin-bitterlich

   on Oct 8, 2018

   More actions

   SteemCommunity/steem#3 is fixing this and the crashes, after review I will do a pr to the steemit repo. ping @theoreticalbts
6. mvandeberg commented on Oct 9, 2018

   

   mvandeberg

   on Oct 9, 2018

   Contributor

   More actions

   Need documentation of API changes from the removal.
7. mac128k

   added

   3

   project/hf20

   and removed

   project/maintenance

   on Oct 9, 2018
8. marvin-bitterlich commented on Oct 9, 2018

   

   marvin-bitterlich

   on Oct 9, 2018

   More actions

   @mvandeberg I have decided for reasons of backwards compatibility to keep apis as is and return dummy values, so these endpoints can be deprecated.

   Exact values returned are https://github.com/SteemCommunity/steem/pull/3/files#diff-f0a8047a921832891adab38f170b4580R25-45

   I added messages to all code parts that need to be removed when deprecation happens to make it easier for the next developer.
9. mvandeberg

   self-assigned this

   on Oct 9, 2018
10. mvandeberg

    added 2 commits that reference this issue on Oct 9, 2018

    Delete bandwidth #3029

    03d1de1

    Remove bandwidth from tests #3029

    ab93289
11. mvandeberg commented on Oct 10, 2018

    

    mvandeberg

    on Oct 10, 2018

    Last edited by mvandeberg

    Contributor

    More actions

    We have discussed internally and decided to remove the deprecated APIs.

    This will cause apps that rely on bandwidth to fail fast. Those apps might be misbehaving currently and failing silently.

    The changed APIs are as follows:

    • condenser_api.get_dynamic_global_properties - Removed the following fields: average_block_size, current_reserve_ratio, max_virtual_bandwidth.

    • Removed the following fields from the extended_account_object: average_bandwidth, lifetime_bandwidth, last_bandwidth_update, average_market_bandwidth, lifetime_market_bandwidth, last_market_bandwidth_update.

    • Removed condenser_api. get_account_bandwidth.

    • Removed the witness_api.
12. mvandeberg

    closed this as completedin #3049on Oct 10, 2018