Bandwidth should be completely removed from code

[Smittyvb]

Original:

Right now it's commented out, but IMO it should be completely removed.

AC:

Delete the bandwidth code in its entirety.
Remove bandwidth related API fields.
Document API changes.

[mvandeberg]

We agree completely. We made the decision to comment it out right now to get it done quickly with the plan to remove it later. Removing it requires a more delicate hand as APIs and other code rely on the bandwidth objects. The current version simply disables the calculations without handling the dependencies in the code that will take more time to remove.

[bobinson]

Thank you @mvandeberg on your inputs.

We made the decision to comment it out right now to get it done quickly with the plan to remove it later.

Just to understand,

1. are we planning to do a new version without completely removing the bandwidth code ?
2. do we plan to test it extensively on the TESNET and make sure that all the side effects of removing the bandwidth code is identified and then, do a release ?

[reggaemuffin]

I'm working on a patch for this. Almost ready, but I am writing tests to make sure nothing is breaking.

Branch: https://github.com/SteemCommunity/steem/tree/feature/remove-bandwith-completely

[reggaemuffin]

SteemCommunity#3 is fixing this and the crashes, after review I will do a pr to the steemit repo. ping @theoreticalbts

[mvandeberg]

Need documentation of API changes from the removal.

[reggaemuffin]

@mvandeberg I have decided for reasons of backwards compatibility to keep apis as is and return dummy values, so these endpoints can be deprecated.

Exact values returned are https://github.com/SteemCommunity/steem/pull/3/files#diff-f0a8047a921832891adab38f170b4580R25-45

I added messages to all code parts that need to be removed when deprecation happens to make it easier for the next developer.

[mvandeberg]

We have discussed internally and decided to remove the deprecated APIs.

This will cause apps that rely on bandwidth to fail fast. Those apps might be misbehaving currently and failing silently.

The changed APIs are as follows:

• condenser_api.get_dynamic_global_properties - Removed the following fields: average_block_size, current_reserve_ratio, max_virtual_bandwidth.

• Removed the following fields from the extended_account_object: average_bandwidth, lifetime_bandwidth, last_bandwidth_update, average_market_bandwidth, lifetime_market_bandwidth, last_market_bandwidth_update.

• Removed condenser_api. get_account_bandwidth.

• Removed the witness_api.