Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support Symfony >2.1 #7

Merged
merged 2 commits into from Nov 17, 2017
Merged

fix: support Symfony >2.1 #7

merged 2 commits into from Nov 17, 2017

Conversation

@gsdevme
Copy link
Contributor

gsdevme commented Nov 16, 2017

replaces #6

foreach ($this->doctrine->getEntityManagers() as $entityManager) {
foreach ($entityManager->getUnitOfWork()->getIdentityMap() as $class => $entities) {
foreach ($this->doctrine->getManagers() as $manager) {
if (!$manager instanceof EntityManagerInterface) {

This comment has been minimized.

Copy link
@steevanb

steevanb Nov 16, 2017

Owner

I'm ok with this code, just replace ! by $manager instanceof EntityManagerInterface === false please :)

This comment has been minimized.

Copy link
@gsdevme

gsdevme Nov 16, 2017

Author Contributor

Sure if you want, I mean instanceof is a type operator.. it cannot be anything other than a boolean.. Im happy to go with it though if you want?

@steevanb steevanb merged commit aaf38a6 into steevanb:master Nov 17, 2017
1 check failed
1 check failed
Scrutinizer Errored
Details
@steevanb

This comment has been minimized.

Copy link
Owner

steevanb commented Nov 17, 2017

You can update to 1.3.2.

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.