From 07e68b092cbc347b4ec420e4e74e07e8cfb19064 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Tue, 29 Nov 2022 11:00:57 +0100 Subject: [PATCH] drivers: fix symbol exports when map is omitted [ upstream commit bfc43a0f681c9069a6e1ef9d18027b0fcfc24afc ] ld exports any global symbol by default if no version script is passed. As a consequence, the incriminated change let any public symbol leak out of the driver shared libraries. Hide again those symbols by providing a default map file which unexports any global symbol using a local: * catch-all statement. The checks are skipped for this default map file as it is intentionnally an empty map (see commit b67bdda86cd4 ("devtools: catch empty symbol maps")) and there is nothing else to check in this map. This change impacts the exported symbols, hence, bump the version in the ABI check to the v22.11.1 from the 22.11 LTS branch. Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded") Reported-by: Luca Boccassi Signed-off-by: David Marchand Tested-by: Ferruh Yigit Reviewed-by: Bruce Richardson Acked-by: Aaron Conole --- .github/workflows/build.yml | 3 ++- .travis.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 82d83f4030f..04a975c787e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -25,7 +25,8 @@ jobs: MINGW: ${{ matrix.config.cross == 'mingw' }} MINI: ${{ matrix.config.mini != '' }} PPC64LE: ${{ matrix.config.cross == 'ppc64le' }} - REF_GIT_TAG: none + REF_GIT_REPO: https://dpdk.org/git/dpdk-stable + REF_GIT_TAG: v22.11.1 RISCV64: ${{ matrix.config.cross == 'riscv64' }} RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }} diff --git a/.travis.yml b/.travis.yml index 4bb5bf629ec..0ea1242d974 100644 --- a/.travis.yml +++ b/.travis.yml @@ -42,7 +42,8 @@ script: ./.ci/${TRAVIS_OS_NAME}-build.sh env: global: - LIBABIGAIL_VERSION=libabigail-1.8 - - REF_GIT_TAG=none + - REF_GIT_REPO=https://dpdk.org/git/dpdk-stable + - REF_GIT_TAG=v22.11.1 jobs: include: