Skip to content
This repository was archived by the owner on Oct 12, 2025. It is now read-only.

Added goto line, fixed search scheme - #4

Merged
stef-k merged 2 commits into
stef-k:masterfrom
Smankusors:master
Jun 28, 2018
Merged

Added goto line, fixed search scheme#4
stef-k merged 2 commits into
stef-k:masterfrom
Smankusors:master

Conversation

@Smankusors

Copy link
Copy Markdown
Contributor

This is for issue #1,
btw I only tried this on Windows, I don't know if this will work on other systems :/

@stef-k

stef-k commented Jun 28, 2018

Copy link
Copy Markdown
Owner

Thanks for your time.

I will test on Linux and proceed accordingly. Hopefully, it will be merged later tonight.

@stef-k

stef-k commented Jun 28, 2018

Copy link
Copy Markdown
Owner

@Smankusors

I've checked the extension on Linux and I needed to do 2 changes in order to make it work.

  1. add n-readlines as dependency in package.json
  2. change link.target = Uri.parse("file:///" + path); to link.target = Uri.parse("file:" + path); from file links.ts line 44.

Can you make these changes, test again on Windows and submit a pull request again?

@Smankusors

Copy link
Copy Markdown
Contributor Author

Alright done, it's working with shorter scheme 😄

@stef-k
stef-k merged commit df25930 into stef-k:master Jun 28, 2018
@stef-k

stef-k commented Jun 28, 2018

Copy link
Copy Markdown
Owner

Tomorrow will upload the new release, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants