Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added goto line, fixed search scheme #4

Merged
merged 2 commits into from Jun 28, 2018
Merged

Conversation

Smankusors
Copy link
Contributor

@Smankusors Smankusors commented Jun 28, 2018

This is for issue #1,
btw I only tried this on Windows, I don't know if this will work on other systems :/

@stef-k
Copy link
Owner

stef-k commented Jun 28, 2018

Thanks for your time.

I will test on Linux and proceed accordingly. Hopefully, it will be merged later tonight.

@stef-k
Copy link
Owner

stef-k commented Jun 28, 2018

@Smankusors

I've checked the extension on Linux and I needed to do 2 changes in order to make it work.

  1. add n-readlines as dependency in package.json
  2. change link.target = Uri.parse("file:///" + path); to link.target = Uri.parse("file:" + path); from file links.ts line 44.

Can you make these changes, test again on Windows and submit a pull request again?

@Smankusors
Copy link
Contributor Author

Smankusors commented Jun 28, 2018

Alright done, it's working with shorter scheme 😄

@stef-k stef-k merged commit df25930 into stef-k:master Jun 28, 2018
@stef-k
Copy link
Owner

stef-k commented Jun 28, 2018

Tomorrow will upload the new release, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants