Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Fix couple of issues that FindBugs brings up.

Still serialization and inefficient new Integer() callse
  • Loading branch information...
commit 053e5ed1fd85bf84d7dc4d43bb243b9eb8660b8c 1 parent 515630d
Rolf authored October 01, 2011
10  core/src/java/org/jdom2/adapters/AbstractDOMAdapter.java
@@ -54,6 +54,7 @@ OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT
54 54
 
55 55
 package org.jdom2.adapters;
56 56
 
  57
+import java.lang.reflect.InvocationTargetException;
57 58
 import java.lang.reflect.Method;
58 59
 
59 60
 import org.jdom2.DocType;
@@ -130,8 +131,13 @@ protected void setInternalSubset(DocumentType dt, String s) {
130 131
 			Method setInternalSubset = dtclass.getMethod(
131 132
 					"setInternalSubset", String.class);
132 133
 			setInternalSubset.invoke(dt, s);
133  
-		}
134  
-		catch (Exception e) {
  134
+		} catch (InvocationTargetException e) {
  135
+			// ignore
  136
+		} catch (IllegalAccessException e) {
  137
+			// ignore
  138
+		} catch (SecurityException e) {
  139
+			// ignore
  140
+		} catch (NoSuchMethodException e) {
135 141
 			// ignore
136 142
 		}
137 143
 	}
2  core/src/java/org/jdom2/output/Format.java
@@ -430,7 +430,7 @@ public Format clone() {
430 430
 	 * to query the JDK 1.4 CharsetEncoder class for unknown charsets.
431 431
 	 * If JDK 1.4 isn't around, default to no special encoding.
432 432
 	 */
433  
-	class DefaultEscapeStrategy implements EscapeStrategy {
  433
+	private final static class DefaultEscapeStrategy implements EscapeStrategy {
434 434
 		private final int bits;
435 435
 		private final CharsetEncoder encoder;
436 436
 

0 notes on commit 053e5ed

Please sign in to comment.
Something went wrong with that request. Please try again.