Skip to content

Commit

Permalink
Merge pull request #11 from johnraz/develop
Browse files Browse the repository at this point in the history
Allow settings.LOGIN_REDIRECT_URL to be a view name
  • Loading branch information
stefanfoulis committed Sep 17, 2014
2 parents e92548b + 87b956e commit e8d5a9f
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions class_based_auth_views/views.py
Expand Up @@ -4,8 +4,7 @@
from django.contrib import auth
from django.contrib.auth import REDIRECT_FIELD_NAME, login
from django.contrib.auth.forms import AuthenticationForm
from django.http import HttpResponseRedirect
from django.shortcuts import redirect
from django.shortcuts import redirect, resolve_url
from django.utils.decorators import method_decorator
from django.views.decorators.cache import never_cache
from django.views.decorators.csrf import csrf_protect
Expand Down Expand Up @@ -62,10 +61,10 @@ def get_success_url(self):

netloc = urlparse.urlparse(redirect_to)[1]
if not redirect_to:
redirect_to = settings.LOGIN_REDIRECT_URL
redirect_to = resolve_url(settings.LOGIN_REDIRECT_URL)
# Security check -- don't allow redirection to a different host.
elif netloc and netloc != self.request.get_host():
redirect_to = settings.LOGIN_REDIRECT_URL
redirect_to = resolve_url(settings.LOGIN_REDIRECT_URL)
return redirect_to

def set_test_cookie(self):
Expand Down Expand Up @@ -116,4 +115,4 @@ def get_redirect_url(self, fallback_url=None, **kwargs):
if fallback_url is None:
fallback_url = settings.LOGIN_URL
kwargs.setdefault("redirect_field_name", self.get_redirect_field_name())
return default_redirect(self.request, fallback_url, **kwargs)
return default_redirect(self.request, fallback_url, **kwargs)

0 comments on commit e8d5a9f

Please sign in to comment.