Skip to content

Merged LoginView post() method into form_valid() and form_invalid() #4

Merged
merged 1 commit into from Apr 9, 2013

2 participants

@jcugat
jcugat commented Apr 8, 2013

Since post() had the same code as the superclass, the custom code has
been moved inside the form.is_valid() condition to form_valid() and
form_invalid().

Also, form_valid() calls the superclass instead of having the same
HttpResponseRedirect.

@jcugat jcugat Merged LoginView post() method into form_valid() and form_invalid()
Since post() had the same code as the superclass, the custom code has
been moved inside the form.is_valid() condition to form_valid() and
form_invalid().

Also, form_valid() calls the superclass instead of having the same
HttpResponseRedirect.
31ed7ab
@stefanfoulis
Owner

thanks @jcugat . That makes a lot of sense.

@stefanfoulis stefanfoulis merged commit 718d10e into stefanfoulis:develop Apr 9, 2013
@jcugat jcugat deleted the unknown repository branch Apr 9, 2013
@jcugat jcugat restored the unknown repository branch Apr 9, 2013
@jcugat jcugat deleted the unknown repository branch Apr 9, 2013
@jcugat jcugat restored the unknown repository branch Apr 9, 2013
@jcugat jcugat deleted the unknown repository branch Apr 9, 2013
@jcugat jcugat restored the unknown repository branch Apr 9, 2013
@jcugat jcugat deleted the unknown repository branch Apr 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.