Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Deprecation Warnings when using SCSS #157

Closed
Damo1155 opened this issue Jun 16, 2020 · 5 comments
Closed

CSS Deprecation Warnings when using SCSS #157

Damo1155 opened this issue Jun 16, 2020 · 5 comments

Comments

@Damo1155
Copy link

Damo1155 commented Jun 16, 2020

I've recently brought the Zebra Datepicker into a couple of our projects via NPM.

Upon including the appropriate references and running the compiler we get the following warning.

DEPRECATION WARNING on line 8, column 8 of <PATH TO SASS FILE>: Including .css files with @import is non-standard behaviour which will be removed in future versions of LibSass.

All our other imports into the SCSS file don't import CSS files directly and instead only reference the SCSS counterpart. After doing some digging around our actual issue is the library doesn't support SCSS.

Are there any plans on migrating the CSS to SCSS or at the very least supporting both SCSS and CSS?

@stefangabos
Copy link
Owner

Zebra_Datepicker is built with SCSS but the scss files are not included with the release files. I will do a release later today with the sass files included.
thanks for the heads-up

@Damo1155
Copy link
Author

Thanks for the update, I look forward to getting the latest version.

@stefangabos
Copy link
Owner

i published a release (1.9.15) which contains the SASS files. have a look and let me know if it works

@Damo1155
Copy link
Author

Thanks for the update.

I’ve just finished work for the day so I’ll make this my first task tomorrow morning.

@Damo1155
Copy link
Author

I've pulled in the latest changes and can confirm it fixes our issue.

Thanks for the quick turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants