Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Firefox bug that broke the timepicker. #145

Closed
wants to merge 1 commit into from

Conversation

@sebipopa
Copy link

commented Aug 3, 2019

The time control element is removed from the DOM and in Firefox the element does not have ".Zebra_Datepicker" as a parent, because it's no longer part of the DOM. By adding this extra condition, everything still works without any masive refactoring. In Chrome the element is removed from the DOM after the condition is verified, that's why this works in Chrome.

An alternative would be to rethink the code so that the DOM is not rewritten every time the date/time changes.

stefangabos added a commit that referenced this pull request Sep 26, 2019
@stefangabos

This comment has been minimized.

Copy link
Owner

commented Sep 26, 2019

I applied a different fix for this one - see 9fa97b5
Thank you!

@sebipopa

This comment has been minimized.

Copy link
Author

commented Sep 27, 2019

Looks like the auto incrementing functionality no longer works. See https://stefangabos.github.io/Zebra_Datepicker/#time

stefangabos added a commit that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.