Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--signoff option is misleading when using --pull-request #76

Open
ehabkost opened this issue Nov 5, 2019 · 0 comments
Open

--signoff option is misleading when using --pull-request #76

ehabkost opened this issue Nov 5, 2019 · 0 comments

Comments

@ehabkost
Copy link
Contributor

ehabkost commented Nov 5, 2019

Quoting @jnsnow , at https://lore.kernel.org/qemu-devel/13430122-c3b2-b68e-8cc8-59e2cb864add@redhat.com/

On 10/31/19 11:02 AM, Peter Maydell wrote:

Hi -- this passed the merge tests but it looks like you forgot
to add your signed-off by line as the submaintainer to Sam's
patches. Could you fix that up and resend, please?

thanks
-- PMM

I bit myself twice with this now: adding --signoff to a pull request
signs the messages that get sent to list, but not the ones that get staged.

Could always be a bug in my local copy, but I'm documenting it on the
list, in case I don't get time to look at this in the next 24h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant