Skip to content
Permalink
Branch: staging
Commits on May 30, 2017
  1. Merge remote-tracking branch 'kwolf/tags/for-upstream' into staging

    Stefan Hajnoczi
    Stefan Hajnoczi committed May 30, 2017
    Block layer patches
    
    # gpg: Signature made Mon 29 May 2017 03:34:59 PM BST
    # gpg:                using RSA key 0x7F09B272C88F2FD6
    # gpg: Good signature from "Kevin Wolf <kwolf@redhat.com>"
    # Primary key fingerprint: DC3D EB15 9A9A F95D 3D74  56FE 7F09 B272 C88F 2FD6
    
    * kwolf/tags/for-upstream:
      block/file-*: *_parse_filename() and colons
      block: Fix backing paths for filenames with colons
      block: Tweak error message related to qemu-img amend
      qemu-img: Fix leakage of options on error
      qemu-img: copy *key-secret opts when opening newly created files
      qemu-img: introduce --target-image-opts for 'convert' command
      qemu-img: fix --image-opts usage with dd command
      qemu-img: add support for --object with 'dd' command
      qemu-img: Fix documentation of convert
      qcow2: remove extra local_error variable
      mirror: Drop permissions on s->target on completion
      nvme: Add support for Controller Memory Buffers
      iotests: 147: Don't test inet6 if not available
      qemu-iotests: Test streaming with missing job ID
      stream: fix crash in stream_start() when block_job_create() fails
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  2. Merge remote-tracking branch 'kraxel/tags/pull-usb-20170529-1' into s…

    Stefan Hajnoczi
    Stefan Hajnoczi committed May 30, 2017
    …taging
    
    usb: depricate legacy options and hmp commands
    usb: fixes for ehci and hub, split xhci variants
    
    # gpg: Signature made Mon 29 May 2017 02:07:17 PM BST
    # gpg:                using RSA key 0x4CB6D8EED3E87138
    # gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>"
    # gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>"
    # gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>"
    # Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138
    
    * kraxel/tags/pull-usb-20170529-1:
      ehci: fix frame timer invocation.
      usb: don't wakeup during coldplug
      usb-hub: set PORT_STAT_C_SUSPEND on host-initiated wake-up
      xhci: add CONFIG_USB_XHCI_NEC option
      xhci: split into multiple files
      usb: Simplify the parameter parsing of the legacy usb serial device
      usb: Deprecate HMP commands usb_add and usb_del
      usb: Deprecate the legacy -usbdevice option
      ehci: fix overflow in frame timer code
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  3. Merge remote-tracking branch 'mst/tags/for_upstream' into staging

    Stefan Hajnoczi
    Stefan Hajnoczi committed May 30, 2017
    pci, virtio, vhost: fixes
    
    A bunch of fixes all over the place. Most notably this fixes
    the new MTU feature when using vhost.
    
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    
    # gpg: Signature made Mon 29 May 2017 01:10:24 AM BST
    # gpg:                using RSA key 0x281F0DB8D28D5469
    # gpg: Good signature from "Michael S. Tsirkin <mst@kernel.org>"
    # gpg:                 aka "Michael S. Tsirkin <mst@redhat.com>"
    # Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
    #      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469
    
    * mst/tags/for_upstream:
      acpi-test: update expected files
      pc: ACPI BIOS: use highest NUMA node for hotplug mem hole SRAT entry
      vhost-user: pass message as a pointer to process_message_reply()
      virtio_net: Bypass backends for MTU feature negotiation
      intel_iommu: turn off pt before 2.9
      intel_iommu: support passthrough (PT)
      intel_iommu: allow dev-iotlb context entry conditionally
      intel_iommu: use IOMMU_ACCESS_FLAG()
      intel_iommu: provide vtd_ce_get_type()
      intel_iommu: renaming context entry helpers
      x86-iommu: use DeviceClass properties
      memory: remove the last param in memory_region_iommu_replay()
      memory: tune last param of iommu_ops.translate()
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  4. Merge remote-tracking branch 'sthibault/tags/samuel-thibault' into st…

    Stefan Hajnoczi
    Stefan Hajnoczi committed May 30, 2017
    …aging
    
    slirp updates
    
    # gpg: Signature made Sat 27 May 2017 10:36:33 PM BST
    # gpg:                using RSA key 0xB0A51BF58C9179C5
    # gpg: Good signature from "Samuel Thibault <samuel.thibault@aquilenet.fr>"
    # gpg:                 aka "Samuel Thibault <sthibault@debian.org>"
    # gpg:                 aka "Samuel Thibault <samuel.thibault@gnu.org>"
    # gpg:                 aka "Samuel Thibault <samuel.thibault@inria.fr>"
    # gpg:                 aka "Samuel Thibault <samuel.thibault@labri.fr>"
    # gpg:                 aka "Samuel Thibault <samuel.thibault@ens-lyon.org>"
    # gpg:                 aka "Samuel Thibault <samuel.thibault@u-bordeaux.fr>"
    # Primary key fingerprint: 900C B024 B679 31D4 0F82  304B D017 8C76 7D06 9EE6
    #      Subkey fingerprint: AEBF 7448 FAB9 453A 4552  390E B0A5 1BF5 8C91 79C5
    
    * sthibault/tags/samuel-thibault:
      Fix total IP header length in forwarded TCP packets
      slirp: fix leak
      slirp: Fix wrong mss bug.
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  5. Merge remote-tracking branch 'jtc/tags/block-pull-request' into staging

    Stefan Hajnoczi
    Stefan Hajnoczi committed May 30, 2017
    # gpg: Signature made Fri 26 May 2017 08:22:27 PM BST
    # gpg:                using RSA key 0xBDBE7B27C0DE3057
    # gpg: Good signature from "Jeffrey Cody <jcody@redhat.com>"
    # gpg:                 aka "Jeffrey Cody <jeff@codyprime.org>"
    # gpg:                 aka "Jeffrey Cody <codyprime@gmail.com>"
    # Primary key fingerprint: 9957 4B4D 3474 90E7 9D98  D624 BDBE 7B27 C0DE 3057
    
    * jtc/tags/block-pull-request:
      block/gluster: glfs_lseek() workaround
      blockjob: use deferred_to_main_loop to indicate the coroutine has ended
      blockjob: reorganize block_job_completed_txn_abort
      blockjob: strengthen a bit test-blockjob-txn
      blockjob: group BlockJob transaction functions together
      blockjob: introduce block_job_cancel_async, check iostatus invariants
      blockjob: move iostatus reset inside block_job_user_resume
      blockjob: separate monitor and blockjob APIs
      blockjob: introduce block_job_pause/resume_all
      blockjob: introduce block_job_early_fail
      blockjob: remove iostatus_reset callback
      blockjob: remove unnecessary check
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  6. Merge remote-tracking branch 'dgibson/tags/ppc-for-2.10-20170525' int…

    Stefan Hajnoczi
    Stefan Hajnoczi committed May 30, 2017
    …o staging
    
    ppc patch queue 2017-05-25
    
    Assorted accumulated patches.  These are nearly all bugfixes at one
    level or another - some for longstanding problems, others for some
    regressions caused by more recent cleanups.
    
    This includes preliminary patches towards fixing migration for Radix
    Page Table guests under POWER9 and also fixing some migration
    regressions due to the re-organization of the interrupt controller
    code.  Not all the pieces are there yet, so those still won't quite
    work, but the preliminary changes make sense on their own.
    
    # gpg: Signature made Thu 25 May 2017 04:50:00 AM BST
    # gpg:                using RSA key 0x6C38CACA20D9B392
    # gpg: Good signature from "David Gibson <david@gibson.dropbear.id.au>"
    # gpg:                 aka "David Gibson (kernel.org) <dwg@kernel.org>"
    # gpg:                 aka "David Gibson (Red Hat) <dgibson@redhat.com>"
    # gpg:                 aka "David Gibson (ozlabs.org) <dgibson@ozlabs.org>"
    # Primary key fingerprint: 75F4 6586 AE61 A66C C44E  87DC 6C38 CACA 20D9 B392
    
    * dgibson/tags/ppc-for-2.10-20170525:
      xics: add unrealize handler
      hw/ppc/spapr.c: recover pending LMB unplug info in spapr_lmb_release
      hw/ppc: migrating the DRC state of hotplugged devices
      hw/ppc: removing drc->detach_cb and drc->detach_cb_opaque
      hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState
      spapr: add pre_plug function for memory
      pseries: Restore support for total vcpus not a multiple of threads-per-core for old machine types
      pseries: Split CAS PVR negotiation out into a separate function
      spapr: fix error reporting in xics_system_init()
      spapr_cpu_core: drop reference on ICP object during CPU realization
      hw/ppc/spapr_events.c: removing 'exception' from sPAPREventLogEntry
      spapr: ensure core_slot isn't NULL in spapr_core_unplug()
      xics_kvm: cache already enabled vCPU ids
      spapr: Consolidate HPT freeing code into a routine
      spapr-cpu-core: release ICP object when realization fails
      spapr: sanitize error handling in spapr_ics_create()
      ppc/xics: simplify prototype of xics_spapr_init()
      target/ppc: reset reservation in do_rfi()
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  7. Merge remote-tracking branch 'armbru/tags/pull-qapi-2017-05-23' into …

    Stefan Hajnoczi
    Stefan Hajnoczi committed May 30, 2017
    …staging
    
    QAPI patches for 2017-05-23
    
    # gpg: Signature made Tue 23 May 2017 12:33:32 PM BST
    # gpg:                using RSA key 0x3870B400EB918653
    # gpg: Good signature from "Markus Armbruster <armbru@redhat.com>"
    # gpg:                 aka "Markus Armbruster <armbru@pond.sub.org>"
    # Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653
    
    * armbru/tags/pull-qapi-2017-05-23:
      qapi-schema: Remove obsolete note from ObjectTypeInfo
      block: Use QDict helpers for --force-share
      shutdown: Expose bool cause in SHUTDOWN and RESET events
      shutdown: Add source information to SHUTDOWN and RESET
      shutdown: Preserve shutdown cause through replay
      shutdown: Prepare for use of an enum in reset/shutdown_request
      shutdown: Simplify shutdown_signal
      sockets: Plug memory leak in socket_address_flatten()
      scripts/qmp/qom-set: fix the value argument passed to srv.command()
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
  8. Merge remote-tracking branch 'ehabkost/tags/numa-pull-request' into s…

    Stefan Hajnoczi
    Stefan Hajnoczi committed May 30, 2017
    …taging
    
    Silence "make check" warnings on NUMA test
    
    # gpg: Signature made Tue 23 May 2017 11:44:24 AM BST
    # gpg:                using RSA key 0x2807936F984DC5A6
    # gpg: Good signature from "Eduardo Habkost <ehabkost@redhat.com>"
    # Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6
    
    * ehabkost/tags/numa-pull-request:
      numa: Silence incomplete mapping warning under qtest
    
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commits on May 29, 2017
  1. Merge remote-tracking branch 'mreitz/tags/pull-block-2017-05-29-v3' i…

    Kevin Wolf
    Kevin Wolf committed May 29, 2017
    …nto queue-block
    
    Block patches for the block queue
    
    # gpg: Signature made Mon May 29 16:32:16 2017 CEST
    # gpg:                using RSA key 0xF407DB0061D5CF40
    # gpg: Good signature from "Max Reitz <mreitz@redhat.com>"
    # Primary key fingerprint: 91BE B60A 30DB 3E88 57D1  1829 F407 DB00 61D5 CF40
    
    * mreitz/tags/pull-block-2017-05-29-v3:
      block/file-*: *_parse_filename() and colons
      block: Fix backing paths for filenames with colons
      block: Tweak error message related to qemu-img amend
      qemu-img: Fix leakage of options on error
      qemu-img: copy *key-secret opts when opening newly created files
      qemu-img: introduce --target-image-opts for 'convert' command
      qemu-img: fix --image-opts usage with dd command
      qemu-img: add support for --object with 'dd' command
      qemu-img: Fix documentation of convert
      qcow2: remove extra local_error variable
    
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  2. block/file-*: *_parse_filename() and colons

    XanClic committed May 22, 2017
    The file drivers' *_parse_filename() implementations just strip the
    optional protocol prefix off the filename. However, for e.g.
    "file:foo:bar", this would lead to "foo:bar" being stored as the BDS's
    filename which looks like it should be managed using the "foo" protocol.
    This is especially troublesome if you then try to resolve a backing
    filename based on "foo:bar".
    
    This issue can only occur if the stripped part is a relative filename
    ("file:/foo:bar" will be shortened to "/foo:bar" and having a slash
    before the first colon means that "/foo" is not recognized as a protocol
    part). Therefore, we can easily fix it by prepending "./" to such
    filenames.
    
    Before this patch:
    $ ./qemu-img create -f qcow2 backing.qcow2 64M
    Formatting 'backing.qcow2', fmt=qcow2 size=67108864 encryption=off
        cluster_size=65536 lazy_refcounts=off refcount_bits=16
    $ ./qemu-img create -f qcow2 -b backing.qcow2 file🔝image.qcow2
    Formatting 'file🔝image.qcow2', fmt=qcow2 size=67108864
        backing_file=backing.qcow2 encryption=off cluster_size=65536
        lazy_refcounts=off refcount_bits=16
    $ ./qemu-io file🔝image.qcow2
    can't open device file🔝image.qcow2: Could not open backing file:
        Unknown protocol 'top'
    
    After this patch:
    $ ./qemu-io file🔝image.qcow2
    [no error]
    
    Signed-off-by: Max Reitz <mreitz@redhat.com>
    Message-id: 20170522195217.12991-3-mreitz@redhat.com
    Reviewed-by: Eric Blake <eblake@redhat.com>
    Signed-off-by: Max Reitz <mreitz@redhat.com>
  3. block: Fix backing paths for filenames with colons

    XanClic committed May 22, 2017
    path_combine() naturally tries to preserve a protocol prefix. However,
    it recognizes such a prefix by scanning for the first colon; which is
    different from what path_has_protocol() does: There only is a protocol
    prefix if there is a colon before the first slash.
    
    A protocol prefix that is not recognized by path_has_protocol() is none,
    and should thus not be taken as one.
    
    Case in point, before this patch:
    $ ./qemu-img create -f qcow2 -b backing.qcow2 ./top:image.qcow2
    qemu-img: ./top:image.qcow2: Could not open './top:backing.qcow2':
        No such file or directory
    
    Afterwards:
    $ ./qemu-img create -f qcow2 -b backing.qcow2 ./top:image.qcow2
    qemu-img: ./top:image.qcow2: Could not open './backing.qcow2':
        No such file or directory
    
    Reported-by: yangyang <yangyang@redhat.com>
    Signed-off-by: Max Reitz <mreitz@redhat.com>
    Reviewed-by: Eric Blake <eblake@redhat.com>
    Message-id: 20170522195217.12991-2-mreitz@redhat.com
    Signed-off-by: Max Reitz <mreitz@redhat.com>
  4. block: Tweak error message related to qemu-img amend

    ebblake authored and XanClic committed May 8, 2017
    When converting a 1.1 image down to 0.10, qemu-iotests 060 forces
    a contrived failure where allocating a cluster used to replace a
    zero cluster reads unaligned data.  Since it is a zero cluster
    rather than a data cluster being converted, changing the error
    message to match our earlier change in 'qcow2: Make distinction
    between zero cluster types obvious' is worthwhile.
    
    Suggested-by: Max Reitz <mreitz@redhat.com>
    Signed-off-by: Eric Blake <eblake@redhat.com>
    Message-id: 20170508171302.17805-1-eblake@redhat.com
    [mreitz: Commit message fixes]
    Signed-off-by: Max Reitz <mreitz@redhat.com>
  5. qemu-img: Fix leakage of options on error

    Fam Zheng authored and XanClic committed May 15, 2017
    Reported by Coverity.
    
    Signed-off-by: Fam Zheng <famz@redhat.com>
    Message-id: 20170515141014.25793-1-famz@redhat.com
    Reviewed-by: Eric Blake <eblake@redhat.com>
    Signed-off-by: Max Reitz <mreitz@redhat.com>
  6. qemu-img: copy *key-secret opts when opening newly created files

    berrange authored and XanClic committed May 15, 2017
    The qemu-img dd/convert commands will create an image file and
    then try to open it. Historically it has been possible to open
    new files without passing any options. With encrypted files
    though, the *key-secret options are mandatory, so we need to
    provide those options when opening the newly created file.
    
    Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
    Message-id: 20170515164712.6643-5-berrange@redhat.com
    Reviewed-by: Max Reitz <mreitz@redhat.com>
    Signed-off-by: Max Reitz <mreitz@redhat.com>
  7. qemu-img: introduce --target-image-opts for 'convert' command

    berrange authored and XanClic committed May 15, 2017
    The '--image-opts' flag indicates whether the source filename
    includes options. The target filename has to remain in the
    plain filename format though, since it needs to be passed to
    bdrv_create().  When using --skip-create though, it would be
    possible to use image-opts syntax. This adds --target-image-opts
    to indicate that the target filename includes options. Currently
    this mandates use of the --skip-create flag too.
    
    Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
    Message-id: 20170515164712.6643-4-berrange@redhat.com
    Reviewed-by: Max Reitz <mreitz@redhat.com>
    Reviewed-by: Eric Blake <eblake@redhat.com>
    Signed-off-by: Max Reitz <mreitz@redhat.com>
  8. qemu-img: fix --image-opts usage with dd command

    berrange authored and XanClic committed May 15, 2017
    The --image-opts flag can only be used to affect the parsing
    of the source image. The target image has to be specified in
    the traditional style regardless, since it needs to be passed
    to the bdrv_create() API which does not support the new style
    opts.
    
    Reviewed-by: Fam Zheng <famz@redhat.com>
    Reviewed-by: Max Reitz <mreitz@redhat.com>
    Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
    Message-id: 20170515164712.6643-3-berrange@redhat.com
    Signed-off-by: Max Reitz <mreitz@redhat.com>
  9. qemu-img: add support for --object with 'dd' command

    berrange authored and XanClic committed May 15, 2017
    The qemu-img dd command added --image-opts support, but missed
    the corresponding --object support. This prevented passing
    secrets (eg auth passwords) needed by certain disk images.
    
    Reviewed-by: Fam Zheng <famz@redhat.com>
    Reviewed-by: Max Reitz <mreitz@redhat.com>
    Reviewed-by: Eric Blake <eblake@redhat.com>
    Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
    Message-id: 20170515164712.6643-2-berrange@redhat.com
    Signed-off-by: Max Reitz <mreitz@redhat.com>
  10. qemu-img: Fix documentation of convert

    Fam Zheng authored and XanClic committed May 15, 2017
    It got lost in commit a8d16f9 "qemu-img: Update documentation for -U".
    
    Reported-by: Max Reitz <mreitz@redhat.com>
    Signed-off-by: Fam Zheng <famz@redhat.com>
    Message-id: 20170515103551.31313-1-famz@redhat.com
    Reviewed-by: Eric Blake <eblake@redhat.com>
    Signed-off-by: Max Reitz <mreitz@redhat.com>
  11. qcow2: remove extra local_error variable

    bertogg authored and XanClic committed May 11, 2017
    Commit d708642 added a local_err
    variable global to the qcow2_amend_options() function, so there's no
    need to have this other one.
    
    Signed-off-by: Alberto Garcia <berto@igalia.com>
    Message-id: 20170511150337.21470-1-berto@igalia.com
    Reviewed-by: Eric Blake <eblake@redhat.com>
    Signed-off-by: Max Reitz <mreitz@redhat.com>
  12. mirror: Drop permissions on s->target on completion

    Kevin Wolf
    Kevin Wolf committed May 29, 2017
    This fixes an assertion failure that was triggered by qemu-iotests 129
    on some CI host, while the same test case didn't seem to fail on other
    hosts.
    
    Essentially the problem is that the blk_unref(s->target) in
    mirror_exit() doesn't necessarily mean that the BlockBackend goes away
    immediately. It is possible that the job completion was triggered nested
    in mirror_drain(), which looks like this:
    
        BlockBackend *target = s->target;
        blk_ref(target);
        blk_drain(target);
        blk_unref(target);
    
    In this case, the write permissions for s->target are retained until
    after blk_drain(), which makes removing mirror_top_bs fail for the
    active commit case (can't have a writable backing file in the chain
    without the filter driver).
    
    Explicitly dropping the permissions first means that the additional
    reference doesn't hurt and the job can complete successfully even if
    called from the nested blk_drain().
    
    Cc: qemu-stable@nongnu.org
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    Acked-by: Paolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: Max Reitz <mreitz@redhat.com>
  13. ehci: fix frame timer invocation.

    kraxel committed May 19, 2017
    ehci registers ehci_frame_timer as both timer and bottom half, which
    turned out to be a bad idea as it can be called as bottom half then
    while it is running as timer, and it isn't prepared to handle recursive
    calls.
    
    Change the timer func to just schedule the bottom half to avoid this.
    
    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1449609
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Message-id: 20170519120428.25981-1-kraxel@redhat.com
  14. usb: don't wakeup during coldplug

    kraxel committed May 23, 2017
    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1452512
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Message-id: 20170523084635.20062-1-kraxel@redhat.com
  15. usb-hub: set PORT_STAT_C_SUSPEND on host-initiated wake-up

    ladipro authored and kraxel committed May 22, 2017
    PORT_STAT_C_SUSPEND should be set even on host-initiated wake-up,
    i.e. on ClearPortFeature(PORT_SUSPEND). Windows is known to not
    work properly otherwise.
    
    Side note, since PORT_ENABLE looks similar and might appear to
    have the same issue: According to 11.24.2.7.2.2 C_PORT_ENABLE:
    
      "This bit is set when the PORT_ENABLE bit changes from one to
      zero as a result of a Port Error condition (see Section 11.8.1).
      This bit is not set on any other changes to PORT_ENABLE."
    
    Signed-off-by: Ladi Prosek <lprosek@redhat.com>
    Message-id: 20170522123325.2199-1-lprosek@redhat.com
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  16. xhci: add CONFIG_USB_XHCI_NEC option

    kraxel committed May 17, 2017
    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1451189
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Message-id: 20170517103313.8459-2-kraxel@redhat.com
  17. xhci: split into multiple files

    kraxel committed May 17, 2017
    Moved structs and defines to hcd-xhci.h.
    Move nec controller variant to hcd-xhci-nec.c.
    No functional changes.
    
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Message-id: 20170517103313.8459-1-kraxel@redhat.com
  18. usb: Simplify the parameter parsing of the legacy usb serial device

    huth authored and kraxel committed May 19, 2017
    Coverity complains about the current code, so let's get rid of
    the now unneeded while loop and simply always emit "unrecognized
    serial USB option" for all unsupported options.
    
    Signed-off-by: Thomas Huth <thuth@redhat.com>
    Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
    Message-id: 1495177204-16808-1-git-send-email-thuth@redhat.com
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  19. usb: Deprecate HMP commands usb_add and usb_del

    huth authored and kraxel committed May 19, 2017
    The commands 'device_add' and 'device_del' should be used
    nowadays instead.
    
    Signed-off-by: Thomas Huth <thuth@redhat.com>
    Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
    Message-id: 1495175803-12830-1-git-send-email-thuth@redhat.com
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  20. usb: Deprecate the legacy -usbdevice option

    huth authored and kraxel committed May 19, 2017
    The '-usbdevice' option is considered as deprecated nowadays and
    we might want to remove these options in a future version of QEMU.
    So mark this options as deprecated in the documenation and print out
    a warning if it is used to tell the user what to use instead.
    While we're at it, improve also some other minor USB-related spots
    in qemu-options.hx that were not up to date anymore.
    
    Signed-off-by: Thomas Huth <thuth@redhat.com>
    Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
    Message-id: 1495175716-12735-1-git-send-email-thuth@redhat.com
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  21. ehci: fix overflow in frame timer code

    kraxel committed May 15, 2017
    In case the frame timer doesn't run for a while due to the host being
    busy skipped_uframes can become big enough that UFRAME_TIMER_NS *
    skipped_uframes overflows.  Which in turn throws off all subsequent
    ehci frame timer calculations.
    
    Reported-by: 李林 <8610_28@163.com>
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
    Message-id: 20170515104543.32044-1-kraxel@redhat.com
  22. acpi-test: update expected files

    mstsirkin committed May 29, 2017
    commit 1a8d61ddbf ("pc: ACPI BIOS: use highest NUMA node for hotplug mem
    hole SRAT entry") changed generated SRAT tables, update expected files
    accordingly.
    
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
  23. pc: ACPI BIOS: use highest NUMA node for hotplug mem hole SRAT entry

    ladipro authored and mstsirkin committed May 25, 2017
    For reasons unknown, Windows won't online all memory, both at command
    line and hot-plugged later, unless the hotplug mem hole SRAT entry
    specifies a node greater than or equal to the ones where memory is
    added.
    
    Using the highest node on the machine makes recent versions of Windows
    happy.
    
    With this example command line:
      ... \
      -m 1024,slots=4,maxmem=32G \
      -numa node,nodeid=0 \
      -numa node,nodeid=1 \
      -numa node,nodeid=2 \
      -numa node,nodeid=3 \
      -object memory-backend-ram,size=1G,id=mem-mem1 \
      -device pc-dimm,id=dimm-mem1,memdev=mem-mem1,node=1
    
    Windows reports a total of 1G of RAM without this commit and the expected
    2G with this commit.
    
    Signed-off-by: Ladi Prosek <lprosek@redhat.com>
    Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Reviewed-by: Igor Mammedov <imammedo@redhat.com>
    Acked-by: Laszlo Ersek <lersek@redhat.com>
Commits on May 27, 2017
  1. Fix total IP header length in forwarded TCP packets

    sgielen authored and sthibaul committed May 24, 2017
    When forwarding TCP packets, the internal tcpiphdr struct length was wrongly
    used inside the IP header. This commit changes the behaviour to what is used
    by tcp_output.c, using the correct full IP header + payload length.
    
    Signed-off-by: Sjors Gielen <sjors@sjorsgielen.nl>
    Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
  2. slirp: fix leak

    elmarco authored and sthibaul committed May 3, 2017
    Spotted by ASAN:
    
    /x86_64/hmp/pc-0.12:
    =================================================================
    ==22538==ERROR: LeakSanitizer: detected memory leaks
    
    Direct leak of 224 byte(s) in 1 object(s) allocated from:
        #0 0x7f0f63cdee60 in malloc (/lib64/libasan.so.3+0xc6e60)
        #1 0x556f11ff32d7 in tcp_newtcpcb /home/elmarco/src/qemu/slirp/tcp_subr.c:250
        #2 0x556f11fdb1d1 in tcp_listen /home/elmarco/src/qemu/slirp/socket.c:688
        #3 0x556f11fca9d5 in slirp_add_hostfwd /home/elmarco/src/qemu/slirp/slirp.c:1052
        #4 0x556f11f8db41 in slirp_hostfwd /home/elmarco/src/qemu/net/slirp.c:506
        #5 0x556f11f8dd83 in hmp_hostfwd_add /home/elmarco/src/qemu/net/slirp.c:535
    
    There might be a better way to fix this, but calling slirp tcp_close()
    doesn't work.
    
    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
  3. slirp: Fix wrong mss bug.

    LeptonWu authored and sthibaul committed Apr 29, 2017
    This bug was introduced by qemu/qemu@98c6305
    
    Signed-off-by: Tao Wu <lepton@google.com>
    Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
    Signed-off-bu: Samuel Thibault <samuel.thibault@ens-lyon.org>
Commits on May 26, 2017
  1. nvme: Add support for Controller Memory Buffers

    sbates130272 authored and Kevin Wolf committed May 16, 2017
    Implement NVMe Controller Memory Buffers (CMBs) which were added in
    version 1.2 of the NVMe Specification. This patch adds an optional
    argument (cmb_size_mb) which indicates the size of the CMB (in
    MB). Currently only the Submission Queue Support (SQS) is enabled
    which aligns with the current Linux driver for NVMe.
    
    Signed-off-by: Stephen Bates <sbates@raithlin.com>
    Acked-by: Keith Busch <keith.busch@intel.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Older
You can’t perform that action at this time.