Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created gradle structure and build file #4

Merged
merged 1 commit into from Aug 30, 2017

Conversation

@mihnita
Copy link
Collaborator

mihnita commented Aug 28, 2017

Also disabled the failing test case.

  • Still using JUnit 3 style (no @RunWith and @Test, and still extending TestCase)
    Wasn't sure if you want to move to JUnit 4. Cleaner to be a separate change anyway.
  • gradle javadoc builds the documentation
  • gradle build and gradle install create the kxml2-2.3.1-sources.jar
    The naming convention is different from the old one, but more "standard"
    (kxml2-2.3.1-sources.jar instead of kxml2-src-2.3.1.zip)
  • Not building the min version (yet?)
apply plugin: 'maven'

group = 'net.sf.kxml'
version = '2.3.1'

This comment has been minimized.

Copy link
@stefanhaustein

stefanhaustein Aug 28, 2017

Owner

Should be the latest tag (+1?)

This comment has been minimized.

Copy link
@mihnita

mihnita Aug 29, 2017

Author Collaborator

I am still figuring out how to update an existing pull request :-)
Can you please update it?

This comment has been minimized.

Copy link
@stefanhaustein

stefanhaustein Aug 29, 2017

Owner

Committ to your branch and do a push, and the pull request will get updated automatically.

group = 'net.sf.kxml'
version = '2.3.1'

sourceCompatibility = 1.7

This comment has been minimized.

Copy link
@stefanhaustein

stefanhaustein Aug 28, 2017

Owner

Should be lower for CLDC compat.

This comment has been minimized.

Copy link
@mihnita

mihnita Aug 29, 2017

Author Collaborator

Please feel free to change the version to whatever is needed.
Still figuring out how to change an existing pull request.


Sorry, I don't know much (anything :-) about CLDC. What version should it be?

What I was able to find was this:
"CLDC 8 is a subset of Java SE 8 that incorporates the language, API, and VM updates."
(http://docs.oracle.com/javame/config/cldc/opt-pkgs/api/cldc/api/index.html)

If there is a way to check compatibility automatically, it would be best :-)

This comment has been minimized.

Copy link
@stefanhaustein

stefanhaustein Aug 29, 2017

Owner

Wasn't aware there is a new version... I think we should keep compatibility with CLDC 1.1 until a major version bump. On wikipedia, I found: "... all Java ME platforms are currently restricted to JRE 1.3 features and use that version of the class file format (internally known as version 47.0)".

@mihnita mihnita force-pushed the mihnita:master branch from 29e2dee to 1ad2522 Aug 29, 2017
@mihnita

This comment has been minimized.

Copy link
Collaborator Author

mihnita commented Aug 29, 2017

Figured out how to update a pull request :-)

Updated version to 2.3.2

Updated Java version to 1.2
This seems crazy old, please change as you wish, or let me know what version to use.
I went with 1.2 based on the version of the .class files in the last public release in maven (2.3.0)

javap -v -cp kxml2-2.3.0.jar org.kxml2.io.KXmlParser | grep version

The results is

  minor version: 0
  major version: 46

and that matches Java 1.2

apply plugin: 'maven'

group = 'net.sf.kxml'
version = '2.3.2'

This comment has been minimized.

Copy link
@stefanhaustein

stefanhaustein Aug 29, 2017

Owner

I think it should be at least 2.4.2, as I have already tagged the last bugfix as 2.4.1 (given the project move and time span -- perhaps a bit early): https://github.com/stefanhaustein/kxml2/releases

In my view, a 2.5.0. would be better for a new project layout.

@mihnita mihnita force-pushed the mihnita:master branch from 1ad2522 to a2a8f0d Aug 30, 2017
@mihnita

This comment has been minimized.

Copy link
Collaborator Author

mihnita commented Aug 30, 2017

Updated library version to 2.5.0 and JKD version to 1.3

@stefanhaustein stefanhaustein merged commit 87f02cd into stefanhaustein:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.