Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
added incidents menu and notifications #14
Woooohooooo! It works! Thanks so much for this.
I only have a few moments now (I'm onboarding a new job) but I'll leave some comments.
No worries. I know starting TS is rough. I'll leave some comments. :)
I fixed the snapshot tests in master. You can update the PR.
stefanjudis left a comment
This is super cool!
I did a high-level check and left some comments. Overall I feel a little bit like the feed class does a little too much. I would extract the time and notification handling. This way the center of the app (menubar) would decide when to fetch the feed and when to notify.
a getFeed function could flag new incidents with a boolean so that the check for notifications could be very straightforward.
What do you think? Thanks again!
@@ Coverage Diff @@ ## master #14 +/- ## ========================================= + Coverage 33.96% 37.27% +3.3% ========================================= Files 8 10 +2 Lines 262 330 +68 Branches 34 44 +10 ========================================= + Hits 89 123 +34 - Misses 171 205 +34 Partials 2 2
stefanjudis left a comment •
Nice – thanks so much for the additional work!
I went over it a little bit more in details and left some comments. :) Please feel free to push back for nits. :)
On a trickier note, i checked out the branch and running
Edited: something is odd, because travis is failing with a weird dep error, too.
Strange? I just made a fresh clone, ran
Okay, I had a deeper look. Here's what I did:
Locked deps with Corrupted electron?
this leads to the following thing
100% drop and install
and a bunch of other ts errors.
Travis is failing with the first case, too. I have honestly no clue. But I guess something is wrong with the lock file and it works for you because you have something sitting in your cache?
The complete reset might then update ts or tslint and this leads to new errors. Could this make sense?
BTW: thanks a bunch that you're still around. This goes for a little bit and I really appreciate it!
No worries! I'm enjoying working on this. Hope it hasn't created too much of a hassle for you.
I just ran the 100% drop and install and am looking at the ts errors now. maybe they're reasonable errors worth fixing?
Not at all. I'm happy about every help with this!
Yeah... they most likely show up due to a dep update that was locked. Fixing now might be the way to go.