New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inspect.signature() on Python 3 #52

Merged
merged 1 commit into from Jul 22, 2016

Conversation

Projects
None yet
3 participants
@vstinner
Contributor

vstinner commented Jun 29, 2016

The inspect.getargspec() function has been deprecated in Python 3:
https://docs.python.org/3/library/inspect.html#inspect.getargspec

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 29, 2016

Coverage Status

Coverage remained the same at 94.753% when pulling 638236d on haypo:signature into c9ac1d9 on stefankoegl:master.

coveralls commented Jun 29, 2016

Coverage Status

Coverage remained the same at 94.753% when pulling 638236d on haypo:signature into c9ac1d9 on stefankoegl:master.

@stefankoegl

This comment has been minimized.

Show comment
Hide comment
@stefankoegl

stefankoegl Jul 22, 2016

Owner

Thanks for your contribution! The Jenkins tests failed for Python 3.2 and pypy3. Can you please have a look and adapt your PR? Thanks :)

Owner

stefankoegl commented Jul 22, 2016

Thanks for your contribution! The Jenkins tests failed for Python 3.2 and pypy3. Can you please have a look and adapt your PR? Thanks :)

Use inspect.signature() on Python 3
The inspect.getargspec() function has been deprecated in Python 3:
https://docs.python.org/3/library/inspect.html#inspect.getargspec
@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Jul 22, 2016

Contributor

Oh, I didn't know that you support Python 3.2. More and more projects are dropping Python 3.2 support. But right, PyPy only officially support Python 3.2 (even if they are actively working on Python 3.5 support).

Anyway, I fixed my change (I fixed the check on the Python version).

Contributor

vstinner commented Jul 22, 2016

Oh, I didn't know that you support Python 3.2. More and more projects are dropping Python 3.2 support. But right, PyPy only officially support Python 3.2 (even if they are actively working on Python 3.5 support).

Anyway, I fixed my change (I fixed the check on the Python version).

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 22, 2016

Coverage Status

Coverage remained the same at 94.753% when pulling d6e9a00 on haypo:signature into c9ac1d9 on stefankoegl:master.

coveralls commented Jul 22, 2016

Coverage Status

Coverage remained the same at 94.753% when pulling d6e9a00 on haypo:signature into c9ac1d9 on stefankoegl:master.

@stefankoegl stefankoegl merged commit 55e0c43 into stefankoegl:master Jul 22, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 94.753%
Details
@stefankoegl

This comment has been minimized.

Show comment
Hide comment
@stefankoegl

stefankoegl Jul 22, 2016

Owner

Nice, thanks :)

Owner

stefankoegl commented Jul 22, 2016

Nice, thanks :)

@vstinner

This comment has been minimized.

Show comment
Hide comment
@vstinner

vstinner Jul 22, 2016

Contributor
Contributor

vstinner commented Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment