Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUse inspect.signature() on Python 3 #52
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Jun 29, 2016
•
This comment has been minimized.
This comment has been minimized.
Thanks for your contribution! The Jenkins tests failed for Python 3.2 and pypy3. Can you please have a look and adapt your PR? Thanks :) |
The inspect.getargspec() function has been deprecated in Python 3: https://docs.python.org/3/library/inspect.html#inspect.getargspec
This comment has been minimized.
This comment has been minimized.
Oh, I didn't know that you support Python 3.2. More and more projects are dropping Python 3.2 support. But right, PyPy only officially support Python 3.2 (even if they are actively working on Python 3.5 support). Anyway, I fixed my change (I fixed the check on the Python version). |
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Jul 22, 2016
•
This comment has been minimized.
This comment has been minimized.
Nice, thanks :) |
This comment has been minimized.
This comment has been minimized.
Thanks.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vstinner commentedJun 29, 2016
The inspect.getargspec() function has been deprecated in Python 3:
https://docs.python.org/3/library/inspect.html#inspect.getargspec