Use lambda for scope in order to be compatible with rails 4 #117

Merged
merged 4 commits into from Apr 3, 2013

Conversation

Projects
None yet
3 participants
@Systho
Contributor

Systho commented Jan 23, 2013

This will break compatiblity with ruby 1.8 and previous versions of rails so it might not be a good idea to merge in master :)

Systho added some commits Jan 23, 2013

Update lib/ancestry/has_ancestry.rb
Use stabby lambda for named scope in order to be compatible with rails 4 and use ruby 1.9 syntax
@sunny

This comment has been minimized.

Show comment
Hide comment
@sunny

sunny Mar 7, 2013

I think using lambda everywhere would be a better tradeoff for the gem to be compatible with Rails 3 and 4.

sunny commented Mar 7, 2013

I think using lambda everywhere would be a better tradeoff for the gem to be compatible with Rails 3 and 4.

Update has_ancestry.rb
used the lambda keyword instead of stabby lambda in order to keep compatibility with older versions
@Systho

This comment has been minimized.

Show comment
Hide comment
@Systho

Systho Apr 2, 2013

Contributor

agreed

Contributor

Systho commented Apr 2, 2013

agreed

@StefanH StefanH merged commit 79e5611 into stefankroes:master Apr 3, 2013

@StefanH

This comment has been minimized.

Show comment
Hide comment
@StefanH

StefanH Apr 3, 2013

Collaborator

Merged it, thanks!

Collaborator

StefanH commented Apr 3, 2013

Merged it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment