Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

sorting nodes and performance #29

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

kueda commented Nov 5, 2010

I added a method to just sort a simple array of nodes by ancestry. Simply sorting by the ancestry column performs a level-order sort, and I wanted something more like a pre-order sort (even though that's not entirely possible given the unordered ranks in the materialized path model. If there's a simpler way to do this, I'd love to know about it.

I also replaced some all.each calls with find_each for improved performance when dealing with very large trees.

Contributor

kueda commented Nov 5, 2010

Uh, I may have screwed up a merge too, since there seems to be a bunch of other commits lumped into this... I thought I just merged in commits from stefankroes/ancestry in the fork queue. Was that not the right way to go about it? github still mystifies me a bit.

Owner

stefankroes commented Nov 15, 2010

I want to include your changes but I think the pull request is kind of screwed up, I will have to check later.

Contributor

kueda commented Nov 16, 2010

Should I do it over again? Or maybe drop my repo, re-fork, and re-apply my changes?

Owner

stefankroes commented Nov 19, 2010

Could you?

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment