Grammar & other perceived improvements #1

Merged
merged 3 commits into from Apr 1, 2012

Conversation

Projects
None yet
2 participants
@waynemoore

I have made some minor grammar corrections / enhancements and reordering of one of the multi-stage examples which I believe may make more sense.

Happy to make any alterations if necessary :)

waynemoore added some commits Mar 29, 2012

Changed order of multi-stage deployment examples.
I think it makes more sense to order them in the way that one would typically use them, i.e. deploy to
staging before deploying to production.
@stefanooldeman

This comment has been minimized.

Show comment
Hide comment
@stefanooldeman

stefanooldeman Mar 31, 2012

Could you but back this sentence, it adds value regarding the example code above (so I believe).

Could you but back this sentence, it adds value regarding the example code above (so I believe).

task :staging do
set :deploy_to, "/u/apps/#{application}-staging/"
set :deploy_via, :copy
after('deploy:symlink', 'cruise_control:build')
end
-When you call `cap production deploy`, two variables are set to production friendly values, and an callback is added to clear the live cache (however that might need to work for your environment), where when you call `cap staging deploy` those same two variables are given different values, and a different callback is registered to tell your imaginary [Cruise Control](http://cruisecontrol.sourceforge.net/) server to rebuild and/or test the latest release.

This comment has been minimized.

@stefanooldeman

stefanooldeman Mar 31, 2012

Owner

Could you but back this sentence, it adds value regarding the example code above (so I believe).
ignore the first comment it somehow was not added as an inline comment

@stefanooldeman

stefanooldeman Mar 31, 2012

Owner

Could you but back this sentence, it adds value regarding the example code above (so I believe).
ignore the first comment it somehow was not added as an inline comment

This comment has been minimized.

@waynemoore

waynemoore Mar 31, 2012

Yes of course - that looks like it got removed by accident - I agree it adds value :)

@waynemoore

waynemoore Mar 31, 2012

Yes of course - that looks like it got removed by accident - I agree it adds value :)

@waynemoore

This comment has been minimized.

Show comment
Hide comment

Done :)

stefanooldeman added a commit that referenced this pull request Apr 1, 2012

Merge pull request #1 from waynemoore/improvements
Grammar & other perceived improvements

@stefanooldeman stefanooldeman merged commit e72a57f into stefanooldeman:master Apr 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment