Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow for option to use uppercase country codes #50

Closed
victorbstan opened this Issue Feb 19, 2014 · 6 comments

Comments

Projects
None yet
2 participants

Would it be possible to add the feature in the 1.0 branch, similar to the way one can indicated iso_codes: true as an option, would something like iso_codes_uppercase: true be an valid fix, until we can use the 2.0 branch?

Alternatively, is the 2.0 branch stable enough that I can use it instead? (i'm using it in conjunction with simple_form gem).

Collaborator

scudco commented Mar 2, 2014

That's a good idea, but I think I'll just add Rails 3 support to 2.0.0. I was going to leave Rails 3 support out of 2.0.0, but I think the Rails 4 code is shaping up nicely. I'd rather just leave the 1.x code behind at this point.

@scudco scudco self-assigned this Mar 2, 2014

Collaborator

scudco commented Mar 2, 2014

I'll ping here when Rails 3 support is added to the 2.0.0 branch. You can follow it here https://github.com/stefanpenner/country_select/tree/2.0.0

Collaborator

scudco commented Mar 3, 2014

@victorbstan still getting the build to pass on Travis, but check out the 2.0.0 branch. Tests are passing with all actionpacks >= 3

https://github.com/stefanpenner/country_select/tree/2.0.0

Collaborator

scudco commented Mar 8, 2014

@victorbstan Closing this with the suggestion that you start using the 2.0.0 branch if you need uppercase ISO codes. Let me know if that solution doesn't work for you for some reason.

@scudco scudco closed this Mar 8, 2014

Hi @scudco I can't access https://github.com/stefanpenner/country_select/tree/2.0.0. How do I install the 2.0 version?

solved: gem 'country_select', :git => "https://github.com/stefanpenner/country_select.git"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment