Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed custom load-grunt-config package #409

Merged
merged 1 commit into from Jan 12, 2014

Conversation

MajorBreakfast
Copy link
Contributor

Fix

@MajorBreakfast
Copy link
Contributor Author

It's not nice. But it's a lot nicer than having to use sudo for npm install

I opened an issue in load-grunt-config: firstandthird/load-grunt-config#24

@MajorBreakfast
Copy link
Contributor Author

@Pradeek I wanted to add that functionality three months ago but thomas deemed it not useful. To be fair renaming the tasks/ folder to grunt was unconventional. I agree that it's useful and now that we have it, we definitly should keep it in until broccoli arrives. In my opinion we have the best grunt folder structure around. The ember yeoman project still used one large file last time I checked :) It's a fight against complexity.

@Pradeek
Copy link
Contributor

Pradeek commented Jan 10, 2014

@MajorBreakfast Agree. EAK definitely has the cleanest Grunt structure I've seen :)

Is any work being done for broccoli at the moment? There is no issue/PR related to it.

@MajorBreakfast
Copy link
Contributor Author

Take a look at the Broccolifile.js. That gives you a bit of an idea of how it's going to look like. I think @joliss's ideas are really good and as you can see the configuration is much more concise. Although the reason for moving away from grunt is that grunt thinks in terms of tasks, not files. The problem is not our complex configuration but that what's really happening inside isn't smart. A change on a particular file should only trigger it's rebuilding. The goal is to do chaching wherever possible. Using the watch task's watch event to configure that is awful. I tried adding it once. It was nasty. Grunt is pretty great but it's the wrong tool for this kind of thing.

@Pradeek
Copy link
Contributor

Pradeek commented Jan 10, 2014

Will check it out and see how I can pitch in. Thanks!

@joliss
Copy link
Collaborator

joliss commented Jan 10, 2014

@MajorBreakfast 👍

stefanpenner added a commit that referenced this pull request Jan 12, 2014
Removed custom load-grunt-config package
@stefanpenner stefanpenner merged commit 3bb1794 into stefanpenner:master Jan 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants