Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep bower_components and vendor separate. #1836

Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Sep 1, 2014

This ensures that import Baz from 'bower_components/foo-bar/baz'; works properly. Prior to this change you would have had to know and understand that we are internally merging bower_components/ and vendor/ together (and therefore you would need to use import Baz from 'vendor/foo-bar/baz';).

No fundamental functionality was lost, but it might be a breaking change for folks that were importing things that happened to be in bower_components/, but were using vendor/ in the import. I'll make sure to call it out as a breaking change in the changelog.

Addresses #1789, in that app.import('bower_components/foo-bar/baz.js') and import Foo from 'bower_components/foo-bar/baz'; now show the proper directories in the errors that spit out.

This ensures that `import Baz from 'bower_components/foo-bar/baz';`
works properly. Prior to this change you would have had to know and
understand that we are internally merging `bower_components/` and
`vendor/` together (and therefore you would need to use `import Baz from
'vendor/foo-bar/baz';`).

No fundamental functionality was lost, but it might be a breaking change
for folks that were importing things that happened to be in
`bower_components/`, but were using `vendor/` in the import.  I'll make
sure to call it out as a breaking change in the changelog.
rwjblue added a commit that referenced this pull request Sep 1, 2014
…s-separate

Keep bower_components and vendor separate.
@rwjblue rwjblue merged commit adc7a43 into ember-cli:master Sep 1, 2014
@jakecraige
Copy link
Member

Nice, that'll be way less confusing to explain to people, lol.

@rwjblue rwjblue deleted the keep-vendor-and-bower_components-separate branch September 5, 2014 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants