Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate package-name.js and package-name.css. #638

Merged
merged 1 commit into from May 8, 2014

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented May 7, 2014

Fixes #485.

@@ -191,7 +191,7 @@ EmberApp.prototype.javascript = memoize(function() {
this.name + '/**/*.js'
],
wrapInEval: this.options.wrapInEval,
outputFile: '/assets/app.js',
outputFile: '/assets/' + this.name + '.js',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the correct case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Currently it will be the same as the name from package.json (which is also used unmodified for the root of all exported modules.

@stefanpenner stefanpenner merged commit 4e2b41a into ember-cli:master May 8, 2014
@stefanpenner
Copy link
Contributor

merged manually

@stefanpenner stefanpenner deleted the use-name-for-assets branch May 8, 2014 03:23
@jbrown jbrown mentioned this pull request May 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name and path of app.js and app.css
2 participants