New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fs tree facade #36
Fs tree facade #36
Conversation
56bb910
to
0682874
Compare
- chomp trailing / for dirs on demand - no more cast; users must supply valid entries, but the duck typing here is very limited (no methods, just need expected properties, may have more properties eg meta)
next up: - implement unlink entries tracking tests - implement optimistic symlinkSync (after confirming there's a failing test in funnel)
This reverts commit 71f0ed0492f689a84759aba3d921b64b042a9c53.
Using slice instead of foreach and push
Updating changes to do sort & expand operations when srcTree is true
slice filteredEntries instead of entries for prevEntries
In chdir, cwd should be base case if if relativePath is '/'.
This is great work, the resulting research lead to several improvements in the ecosystem. This PR itself though should likely be closed, as we will most likely not be actively pursuing this approach in the near term. Additionally the code-base has changed drastically, if we do explore this again it will look very different. We will still have this PR around for history, and context, but we closing it seems appropriate. |
Knowledge from this has been used to implemented by https://github.com/broccolijs/fs-merger + https://github.com/broccolijs/broccoli-output-wrapper which is in mainline broccoli now. Further work is possible, but should likely be explored independently of this project. :) |
playing around with a more complete FS facade \w change tracking.
applyOutput
@krisseldendirectories
in writeFileSync @krisseldenFix #59