New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to awesome-cakephp #16

Closed
dereuromark opened this Issue Mar 30, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@dereuromark
Contributor

dereuromark commented Mar 30, 2015

Did you consider adding your plugin to the awesome list ?

If so, is there a reason to keep your current license? Most (99%) CakePHP (plugin) code runs under the MIT license.
Not a big deal, just asking if there is a specific reason, and if MIT would also do.

Also, some basic test coverage (via travis) would be needed to ensure quality and prevent basic regressions.

@stefanvangastel

This comment has been minimized.

Show comment
Hide comment
@stefanvangastel

stefanvangastel Mar 30, 2015

Owner

Thanks Mark, will do that! Was planning some maintenance and updating anyway. Will keep you posted.

Owner

stefanvangastel commented Mar 30, 2015

Thanks Mark, will do that! Was planning some maintenance and updating anyway. Will keep you posted.

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark

dereuromark Apr 28, 2016

Contributor

Cool
A 3.x version would also be awesome :)

Contributor

dereuromark commented Apr 28, 2016

Cool
A 3.x version would also be awesome :)

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark

dereuromark Dec 27, 2017

Contributor

PS: Is it MIT or GPL license? composer states MIT, but license file says otherwise.
I would recommend using the standard non copy left MIT here for both.
To fix that would be important as otherwise this is not usable as plugin for many people without violating copyright law.

Contributor

dereuromark commented Dec 27, 2017

PS: Is it MIT or GPL license? composer states MIT, but license file says otherwise.
I would recommend using the standard non copy left MIT here for both.
To fix that would be important as otherwise this is not usable as plugin for many people without violating copyright law.

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark

dereuromark Dec 27, 2017

Contributor

I took the liberty of upgrading to 3.x and apply some improvements.
as soon as we figured out the license issue I can push it into a repository for us.

Contributor

dereuromark commented Dec 27, 2017

I took the liberty of upgrading to 3.x and apply some improvements.
as soon as we figured out the license issue I can push it into a repository for us.

@stefanvangastel

This comment has been minimized.

Show comment
Hide comment
@stefanvangastel

stefanvangastel Dec 27, 2017

Owner

Awesome, if you have a PR ready, pls do change to MIT.

Owner

stefanvangastel commented Dec 27, 2017

Awesome, if you have a PR ready, pls do change to MIT.

@dereuromark

This comment has been minimized.

Show comment
Hide comment
@dereuromark

dereuromark Jan 5, 2018

Contributor

PR done.

Contributor

dereuromark commented Jan 5, 2018

PR done.

@dereuromark dereuromark closed this Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment