Update default email address of github-actions[bot]#264
Update default email address of github-actions[bot]#264stefanzweifel merged 1 commit intostefanzweifel:masterfrom
Conversation
|
Thanks! I will take a closer look later today. |
stefanzweifel
left a comment
There was a problem hiding this comment.
Changes look okay and everything works as expected.
But I don't understand why this change is exactly necessary.
(I personally like, that the used email by the Action is "clean" and doesn't contain an ID.)
Do you think this should be changed, because the Action was created after July 2017? Like how GitHub explains the difference of the email addresses on their docs page.
Where did you get the 41898282 ID from? Did you figure the ID out by using an API endpoint?
Did you ran into any issues with the old way of how the Action works?
Thanks for your feedback.
|
Originally there were two reasons why I started looking into this: some of the commits made by actions were If you look at the API, the user was created on So I think the right email to use would be the one with the ID, but you could double check it of course to see if you see the same behaviour in workflows, just to make sure :) |
|
Thanks for the explanation. Will merge this to |
GitHub uses the new email format by default at commits when the
github-actions[bot]is being used. This should bring it inline with that.