Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Merge pull request #712 from steffendietz/confirm-upgrade

updated upgrade instructions, minor code style upgrade
  • Loading branch information...
commit 8ea96c8488ea5fe34b2891fd868b958bdbcf5ef7 2 parents a322bfb + 610689a
Alexander Makarov samdark authored
Showing with 12 additions and 2 deletions.
  1. +11 −1 UPGRADE
  2. +1 −1  framework/console/CConsoleCommand.php
12 UPGRADE
View
@@ -21,7 +21,17 @@ General upgrade intructions
Upgrading from v1.1.10
----------------------
-- API of protected method CConsoleCommand::afterAction() changed, if you are overiding this method make sure to update your code.
+- API of public method CConsoleCommand::confirm() changed. If you are overriding this method make sure to update your code.
+ The method now has a 2nd parameter for the default value which will be used if no selection is made, so you have to
+ adjust the signature to fit
+
+ public function confirm($message,$default=false)
+
+ and the parent call to
+
+ parent::confirm($message,$default);
+
+- API of protected method CConsoleCommand::afterAction() changed, if you are overriding this method make sure to update your code.
method now has a 3rd parameter for application exit code, so you have to adjust the signature to fit
protected function afterAction($action,$params,$exitCode=0)
2  framework/console/CConsoleCommand.php
View
@@ -557,7 +557,7 @@ public function prompt($message,$default=null)
*
* @since 1.1.9
*/
- public function confirm($message, $default = false)
+ public function confirm($message,$default=false)
{
echo $message.' (yes|no) [' . ($default ? 'yes' : 'no') . ']:';
Please sign in to comment.
Something went wrong with that request. Please try again.