Adds scenario for if a user does not want to install asdf on Ubuntu #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #3 Hole in the test coverage! We are not testing if a user wishes to skip the asdf install on this playbook (which would just do nothing to the target instance). The ability to opt-out is a huge selling point for eng. This adds an automated scenario for Linux. It does not cover macOS because the macOS tests take almost an order of magnitude longer to run in GitHub Actions, so leaving macOS off and considering it "good enough", but the code path is different so there is some risk going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3
Hole in the test coverage! We are not testing if a user wishes to skip
the asdf install on this playbook (which would just do nothing to the
target instance). The ability to opt-out is a huge selling point for
eng. This adds an automated scenario for Linux. It does not cover macOS
because the macOS tests take almost an order of magnitude longer to run
in GitHub Actions, so leaving macOS off and considering it "good
enough", but the code path is different so there is some risk going
forward.