From 706e0bc8398036fda3fedba4dc01d74d05271975 Mon Sep 17 00:00:00 2001 From: Stein Fletcher Date: Fri, 11 Oct 2019 21:51:24 +0100 Subject: [PATCH] Ignore fields not market with tag --- secretsmanager/conf.go | 4 ++++ secretsmanager/conf_test.go | 1 + 2 files changed, 5 insertions(+) diff --git a/secretsmanager/conf.go b/secretsmanager/conf.go index 5446b7f..da870f9 100644 --- a/secretsmanager/conf.go +++ b/secretsmanager/conf.go @@ -22,6 +22,10 @@ func NewProvider(secretsManager secretsmanageriface.SecretsManagerAPI) conf.Prov func (o asmConf) Provide(field reflect.StructField) (string, error) { key, opts := parseTag(field, "secret") + if key == "" { + return "", nil + } + defaultValue, _ := parseTag(field, "secretDefault") isRequired := hasOption(opts, "required") diff --git a/secretsmanager/conf_test.go b/secretsmanager/conf_test.go index ab0fe54..a49f00d 100644 --- a/secretsmanager/conf_test.go +++ b/secretsmanager/conf_test.go @@ -16,6 +16,7 @@ import ( ) type config struct { + OtherField string SecretPlaintext string `secret:"/my-group/my-secret"` }