Revert delegate setting related commits #253

Merged
merged 1 commit into from Mar 5, 2013

Projects

None yet

2 participants

@sibljon
Contributor
sibljon commented Mar 5, 2013

This reverts the following commits:

  • efc4f99 (modify delegate setting)
  • bca811f (comment on the modification
    that was made)

As it turns out, this is:

  1. A typo (it should check if self != nil)
  2. Not setting extVars.collectionViewDelegate when == self is not the right solution, since it blocks calls to PSTCollectionView's functional implementation of UIScrollViewDelegate methods (such as scrollViewDidEndDragging:willDecelerate:)

As I said in #251, I'm going to try to use an instance of HTDelegateProxy and remove PSTCollectionView's UIScrollViewDelegate method forwarding. Perhaps Apple is using something similar to HTDelegateProxy to forward invocations, while avoiding the callback loop.

@sibljon sibljon Revert commits related to delegate setting
This reverts the following commits:
- efc4f99 (modify delegate setting)
- bca811f (comment on the modification
that was made)
475bc25
@steipete steipete merged commit 45c19b8 into steipete:master Mar 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment