Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect TV type from filename #561

Closed
thrust26 opened this issue Jan 20, 2020 · 8 comments
Closed

Detect TV type from filename #561

thrust26 opened this issue Jan 20, 2020 · 8 comments
Assignees
Milestone

Comments

@thrust26
Copy link
Member

thrust26 commented Jan 20, 2020

It is impossible for Stella to detect why TV type a game is meant for except by checking the scanlines it produces. So e.g. PAL-60 and NTSC will always be auto detected as NTSC.

The idea is to define the TV type in this order:

  1. command line
  2. game's properties
  3. game's filename
  4. auto detection
@thrust26 thrust26 added this to the Prio 2 milestone Jan 20, 2020
@thrust26 thrust26 self-assigned this Jan 20, 2020
@sa666666
Copy link
Member

All PAL60 ROMs currently (or should) have '(PAL60)' in the filename, at least if you use ROM audit and rename them according to RomHunter database. Searching for 'PAL60' (case insensitive) should suffice for this. I think NTSC50 and the SECAM varieties are rare enough that we probably don't need to care, but I guess looking for those strings is possible too.

@sa666666
Copy link
Member

One other thing; to be consistent we need to consider the bankswitch scheme extension too. In that case, it overrides the game properties and autodetection. So filename contents should be checked first, then game properties, then autodetect.

@thrust26
Copy link
Member Author

thrust26 commented Jan 21, 2020

When does it make sense to override properties for bankswitching or TV type with the filename? IMO they should always be checked first, after command line parameters that is (updated above).

@sa666666
Copy link
Member

OK, so maybe choosing the bankswitching scheme needs to be done the same way. I suppose it doesn't really matter; I was just thinking of consistency.

@sa666666
Copy link
Member

To add to this: I consider naming a file and using the commandline as an external action, done by the user. So that should override anything built into Stella (so, it overrides ROM properties and autodetect). That's why I place commandline and file naming as having higher priority. That's how the BS scheme selection is done, but perhaps it doesn't make as much sense for the TV type? Although I think they should be the same.

@thrust26
Copy link
Member Author

Agreed, should be identical.

The command line is always user input, but the filename may originate from somewhere else. So IMO it is not exactly user input. That's why I would prefer properties over filename.

@sa666666
Copy link
Member

OK, you can go ahead and implement it as you think is best, and I will update the BS stuff to match it afterwards.

@thrust26
Copy link
Member Author

Will do.

One question: Should we update the game's properties from the filenames?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants