Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for go1.13, drop support for go1.11 #1696

Closed
3 tasks done
leighmcculloch opened this issue Sep 3, 2019 · 0 comments · Fixed by #1700
Closed
3 tasks done

Add support for go1.13, drop support for go1.11 #1696

leighmcculloch opened this issue Sep 3, 2019 · 0 comments · Fixed by #1700
Assignees
@leighmcculloch

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Sep 3, 2019 •
edited

As part of #1548 we started only maintaining support for the last two versions of Go. See that issue for more information on why.

Go 1.13 was released today, which makes Go 1.11 no longer supported with security updates.

There should be no code changes to support building in Go 1.13 as it already appears that all our tests pass on Go 1.13. We need to update docs and CI builds to remove Go 1.11 and make the supported and tested versions Go 1.12 and Go 1.13.

  • Replace mentions of Go 1.11 and 1.12, with Go 1.12 and 1.13.
  • Update CI builds
  • Fix scripts that are specifically dependent on running certain checks with only Go 1.11 (e.g. govet.sh)
@leighmcculloch leighmcculloch self-assigned this Sep 3, 2019
@leighmcculloch leighmcculloch changed the title add support for go1.13, drop support for go1.11 Add support for go1.13, drop support for go1.11 Sep 3, 2019
@leighmcculloch leighmcculloch mentioned this issue Sep 4, 2019
Merged
7 tasks
leighmcculloch added a commit that referenced this issue Sep 4, 2019
@leighmcculloch
all: drop support for go1.11, add support for go1.13 (#1700)
31321a3 
Add testing and support for Go 1.13 and discontinue support for Go 1.11.

To maintain consistency with supported and released versions of Go. Go provides security updates for the last two versions of Go, this means the current release (1.13) and the previous release (1.12). Go 1.13 was released today meaning security updates will no longer be released for Go 1.11.

Go 1.13 also comes with several new features relating to Modules including more efficient and reliable downloading of dependencies. As we switch to using Modules it will be a better experience for all and we'll be making the most of the change to promote and use Go 1.13.

Close #1696 

Summary of changes:
- Update 1.13 builds to use latest release of 1.13.
- Remove 1.11 from builds.
- Update all documentation references of supported versions of Go.
- Update `govet.sh` to use `-vettool` option that was added in Go 1.12. This was an outstanding TODO item in the file already, but we needed to do it to make the file work with Go 1.12+. Closes #1038.
- Add notes to changelogs.

Known limitations & issues:
There is a bug in the Go 1.13's `go vet` tool that prevents it from being used with shadow. For this reason only the standard vet checks run on Go 1.13 builds, and the additional shadow check runs on Go 1.12 only. I stumbled onto this issue and opened an issue here for it: golang/go#34053.
@leighmcculloch leighmcculloch mentioned this issue Sep 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leighmcculloch leighmcculloch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

all: drop support for go1.11, add support for go1.13
1 participant
@leighmcculloch