services/horizon: Update v2.3.0 changelog to reflect all PRs since 2.2.0 #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
reviewed
May 6, 2021
services/horizon/CHANGELOG.md
Outdated
| ### Code changes | ||
| * Improved test suite coverage and stability ([3560](https://github.com/stellar/go/pull/3560), [3562](https://github.com/stellar/go/pull/3562), [3551](https://github.com/stellar/go/pull/3551), and [3547](https://github.com/stellar/go/pull/3547)). | ||
|
|
||
| * Refactored ingestion library to hide `TransactionMeta` field ([3561](https://github.com/stellar/go/pull/3561)). |
There was a problem hiding this comment.
I think this (about TransactionMeta) is too low level for Horizon users. The rest under "Code changes" seems fine.
There was a problem hiding this comment.
Are we still releasing the ingestion library as a separate package? If so you're right, this should probably go in that (new) CHANGELOG instead.
There was a problem hiding this comment.
Yes, we should add a CHANGELOG file to ingest package and release a new version.
2opremio
approved these changes
May 11, 2021
2opremio
reviewed
May 12, 2021
2opremio
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.