More fixes #324

Merged
merged 5 commits into from Jan 12, 2017

Projects

None yet

3 participants

@nullstyle
Member
nullstyle commented Jan 11, 2017 edited

This PR rolls up a couple of fixes related to trades that didn't make it into yesterday's release.

Scott Flecke... and others added some commits Jan 11, 2017
Scott Fleckenstein Fix missing amounts in order_book/trades endpoint 971495e
Scott Fleckenstein Fixes #322 9c5aa1e
Scott Fleckenstein Update changelog 055353b
@nullstyle nullstyle Merge branch 'master' into more-fixes
f4e407d
@nullstyle nullstyle requested review from jedmccaleb and bartekn Jan 11, 2017
src/github.com/stellar/horizon/test/t.go
@@ -47,6 +51,22 @@ func (t *T) ScenarioWithoutHorizon(name string) *T {
return t
}
+// UnmarshalPage populares dest with the records contained in the json-encoded
@bartekn
bartekn Jan 11, 2017 Member

populates

@@ -85,17 +85,17 @@ func TestGetOrderBookSummary_Regress310(t *testing.T) {
// 0.1, 0.2, and 0.3 should appear first, when the
// query is correct. In a failing scenario the 0.2
// transaction should not appear.
@bartekn
bartekn Jan 11, 2017 Member

Comment needs to be updated.

@nullstyle
nullstyle Jan 11, 2017 Member

oh snap, thanks! I'll fix it now. I'm always bad at maintaining comments.

@nullstyle Scott Fleckenstein Comment fixes
f5bd48c
@jedmccaleb
Member

r+

@nullstyle nullstyle merged commit 4e37310 into master Jan 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment