Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperationCallBuilder should include a method to provide optional join arguments to Horizon. #433

Closed
marcinx opened this issue Sep 7, 2019 · 2 comments · Fixed by #436
Closed
Assignees

Comments

@marcinx
Copy link

marcinx commented Sep 7, 2019

Is your feature request related to a problem? Please describe.
Recently Horizon started supporting an optional join parameter on its /operations endpoint. Unfortunately it currently isn't possible to pass the join argument to the OperationCallBuilder (https://stellar.github.io/js-stellar-sdk/OperationCallBuilder.html) -- at least I am not aware of a way to do so.

Describe the solution you'd like
OperationCallBuilder should include a method .join() that propagates to the join parameter to the /operations endpoint.

Describe alternatives you've considered
Currently we need to query operations and then query the transaction for every single result to obtain the memo. Using the join parameter lets us query operation details and memo in a single round-trip.

Additional context
The join method should allow for comma separated values, to allow flexibility in the future, when e.g. effects are added to the list of supported join options.

@abuiles @tomquisel

@ire-and-curses
Copy link
Member

For reference, Go SDK implementation is here: stellar/go#1521

@abuiles
Copy link
Contributor

abuiles commented Sep 13, 2019

@marcinx this has been released in 3.0.1 https://github.com/stellar/js-stellar-sdk/releases/tag/v3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants