fix: update simulationData after re-simulation #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadoh
force-pushed
the
fix/sim-data-cache
branch
from
317dcb5
to
446ac24
Compare
Shaptic
approved these changes
Jun 13, 2024
The new test added here shows that you can edit a transaction with `tx.raw = cloneFrom(tx.build)` and that the `tx.simulationData` will be updated correctly.
chadoh
force-pushed
the
fix/sim-data-cache
branch
from
446ac24
to
cc8ec5d
Compare
|
Added the changelog entry. One of these days I'll start remembering without being asked! 😅 |
Merged
BlaineHeffron
pushed a commit
to AhaLabs/js-stellar-sdk
that referenced
this pull request
Jun 20, 2024
The new test added here shows that you can edit a transaction with `tx.raw = cloneFrom(tx.build)` and that the `tx.simulationData` will be updated correctly.
This was referenced Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test added here shows that you can edit a transaction with
tx.raw = cloneFrom(tx.build)and that thetx.simulationDatawill be updated correctly.simulationDatais effectively a cache, and we need to make sure we clear it when you re-simulate.