Add in contract assertions to prng functions #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
commented
Jul 12, 2024
There was a problem hiding this comment.
There are more places we can drop this assertion, such as the deploy functions. I'm marking the original issue #1165 as closed after this change because once this has merged we have addressed the two biggest occurrences where folks get confused which is the storage and prng APIs.
dmkozh
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add in contract assertions to prng functions.
Why
It's really easy to think you can use the prng functions inside your tests to help setup random test data, without reaslising that these functions are restricted to use within a contract.
Close #1165