Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Map strkeys (e.g. G...) to FixedBinary<32> #53

Closed
leighmcculloch opened this issue Aug 2, 2022 · 2 comments · Fixed by #71
Closed

CLI: Map strkeys (e.g. G...) to FixedBinary<32> #53

leighmcculloch opened this issue Aug 2, 2022 · 2 comments · Fixed by #71

Comments

@leighmcculloch
Copy link
Member

leighmcculloch commented Aug 2, 2022

People will naturally want to use Stellar's strkey format for keys as inputs to functions or arguments to things. We should map this to FixedBinary<32> or to some other type, so that people can continue to use those keys. Possibly now is the right time to finish implementing the PublicKey type that is still in the XDR.

cc @paulbellamy @jayz22 @jonjove

I'm revisiting this because of this question in Discord by @fsodano:
https://discord.com/channels/897514728459468821/966788672164855829/1003810451408306246

@paulbellamy
Copy link
Contributor

Can we improve and re-use https://github.com/stellar/rs-stellar-strkey ?

@leighmcculloch
Copy link
Member Author

Yes I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants