Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set base reserve or fee to 0 using stellar-core command line #1594

Closed
zulucrypto opened this issue Mar 10, 2018 · 3 comments
Closed

Comments

@zulucrypto
Copy link

To reproduce:

# stellar-core --c "upgrades?mode=set&upgradetime=2000-01-01T00:00:00Z&basereserve=0"
Content-Length: 71
Content-Type: application/json

2018-03-10T01:20:46.952 GBZER [default INFO] could not parse basereserve: '0'
Failed to parse 'basereserve' argument

I was trying this on a private network since this stack exchange question got me curious: https://stellar.stackexchange.com/questions/649/is-it-possible-to-create-a-private-stellar-network-without-transactions-fees

@MonsieurNicolas
Copy link
Contributor

Yes this is by design 0 is not a valid value ; mostly a guardrail as people can still put 1.

@munawarb
Copy link

It would be nice to be able to set fees to 0 on a private network. I've set my basefee and basereserve values to 1 but this doesn't eliminate the fees entirely because it's some constant multiplied by basefee and basereserve.

@feelingsonice
Copy link

@MonsieurNicolas can you point me to where these values parameter checks are so that I may modify it for a private network?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants