Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code issue: quorum intersection code depends on "app" and "herder" #2152

Closed
MonsieurNicolas opened this issue Jun 17, 2019 · 0 comments · Fixed by #2153
Closed

code issue: quorum intersection code depends on "app" and "herder" #2152

MonsieurNicolas opened this issue Jun 17, 2019 · 0 comments · Fixed by #2153
Assignees
@graydon
Labels
bug

Comments

@MonsieurNicolas
Copy link
Contributor

I missed this during code review:

the "scp" folder is used by other projects outside of stellar and as such we try to keep it as independent as possible from the rest of stellar-core.

The way it is coded, it adds a dependency on "Herder" and on "Config".

I think that the simplest thing to do is to move those files into the "Herder" folder; there might be something cleaner to do (maybe using some new types), but I am not sure it's worth it at this time.
@graydon graydon mentioned this issue Jun 18, 2019
Merged
Geod24 added a commit to Geod24/stellar-core that referenced this issue Feb 5, 2020
@Geod24
Remove forward-declaration of stellar::Config from SCP
4bfa83c 
It was originally added as part of PR stellar#2127,
and should have been removed as part of the fix for stellar#2152.
@AndrejMitrovic AndrejMitrovic mentioned this issue Mar 12, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graydon graydon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug 2152 move quorum intersection checker graydon/stellar-core
2 participants
@graydon @MonsieurNicolas