New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build on netbsd #1043

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@codeck
Contributor

codeck commented Jun 22, 2016

tested on raspberry pi

@jedmccaleb

This comment has been minimized.

jedmccaleb commented on 61a6aad Jun 22, 2016

r+

@latobarita

This comment has been minimized.

Contributor

latobarita commented on 61a6aad Jun 22, 2016

saw approval from jedmccaleb
at strllar@61a6aad

This comment has been minimized.

Contributor

latobarita replied Jun 22, 2016

merging strllar/stellar-core/rpi = 61a6aad into auto

This comment has been minimized.

Contributor

latobarita replied Jun 22, 2016

strllar/stellar-core/rpi = 61a6aad merged ok, testing candidate = 3f22b9e

This comment has been minimized.

Contributor

latobarita replied Jun 22, 2016

latobarita added a commit that referenced this pull request Jun 22, 2016

Merge pull request #1043 from strllar/rpi
build on netbsd

Reviewed-by: jedmccaleb
@codeck

This comment has been minimized.

Contributor

codeck commented Dec 14, 2016

how to?

@@ -75,7 +75,7 @@
# define _ELPP_OS_FREEBSD 1
#endif
// Unix
#if ((_ELPP_OS_LINUX || _ELPP_OS_MAC || _ELPP_OS_FREEBSD) && (!_ELPP_OS_WINDOWS))
#if ((_ELPP_OS_LINUX || _ELPP_OS_MAC || _ELPP_OS_FREEBSD || __unix__) && (!_ELPP_OS_WINDOWS))

This comment has been minimized.

@mvaneijk

mvaneijk Dec 14, 2016

I don't think you should modify a library file, is this change necessary?

This comment has been minimized.

@codeck

codeck Dec 14, 2016

Contributor

the better way is make a upstream pull request. but i think it's ok in practical. it's necessary if you want to build on netbsd, which is the only os to support stellar-core on raspberry pi.

@MonsieurNicolas

This comment has been minimized.

Contributor

MonsieurNicolas commented Mar 30, 2018

closing this, I think this was actually fixed when we picked up a new version of easylogging a while back

@MonsieurNicolas

This comment has been minimized.

Contributor

MonsieurNicolas commented Mar 30, 2018

and asio more recently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment