Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update xdrpp to get rid of empty unions (which now cause clang warnings) #2353

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@stanford-scs
Copy link

stanford-scs commented Nov 20, 2019

Description

When generating code for unions in which every arm is void, avoid generating the empty union.

Checklist

  • [ x] Reviewed the contributing document
  • [ x] Rebased on top of master (no merge commits)
  • [ x] Ran clang-format v5.0.0 (via make format or the Visual Studio extension)
  • [ x] Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document
@MonsieurNicolas MonsieurNicolas added this to In progress in v12.2.0 via automation Nov 20, 2019
@MonsieurNicolas

This comment has been minimized.

Copy link
Contributor

MonsieurNicolas commented Nov 20, 2019

r+ 63c2e1d

@latobarita

This comment has been minimized.

Copy link
Contributor

latobarita commented on 63c2e1d Nov 20, 2019

saw approval from MonsieurNicolas
at xdrpp@63c2e1d

This comment has been minimized.

Copy link
Contributor

latobarita replied Nov 20, 2019

merging xdrpp/stellar-core/dm/suppress-empty-unions = 63c2e1d into auto

This comment has been minimized.

Copy link
Contributor

latobarita replied Nov 20, 2019

xdrpp/stellar-core/dm/suppress-empty-unions = 63c2e1d merged ok, testing candidate = b97d84b

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

latobarita replied Nov 20, 2019

fast-forwarding master to auto = b97d84b

latobarita added a commit that referenced this pull request Nov 20, 2019
update xdrpp to get rid of empty unions (which now cause clang warnings)

Reviewed-by: MonsieurNicolas
@latobarita latobarita merged commit 63c2e1d into stellar:master Nov 20, 2019
1 check passed
1 check passed
default all tests passed
Details
v12.2.0 automation moved this from In progress to Done Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v12.2.0
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.