Skip to content

Wait for soroban upgrades to prevent races with loadgen#392

Merged
marta-lokhova merged 1 commit into
stellar:mainfrom
marta-lokhova:properlyWaitForSorobanUpgrades
Jun 5, 2026
Merged

Wait for soroban upgrades to prevent races with loadgen#392
marta-lokhova merged 1 commit into
stellar:mainfrom
marta-lokhova:properlyWaitForSorobanUpgrades

Conversation

@marta-lokhova

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 5, 2026 17:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves reliability of the mixed pre-generated Soroban-limit upgrade flow by explicitly waiting for the full set of configured Soroban limits to become visible on a peer before proceeding, reducing the chance of races with subsequent load generation.

Changes:

  • Add a consolidated poll/wait that verifies all relevant MIXED_PREGEN_* Soroban limits (ledger + tx) are applied before continuing.
  • Refactor limit computation into a single record (MixedPregenSorobanLimits) to reduce duplication and ensure consistent values are used for both upgrade creation and waiting.
  • Adjust slp_eval.sh evaluation defaults by lowering NETWORK_SIZE_LIMIT.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/FSLibrary/MinBlockTimeTest.fs Adds a single polling loop that waits until all upgraded Soroban limits match expected values, preventing races with loadgen.
scripts/slp_eval.sh Changes the evaluation wrapper’s default network size limit (277 → 100).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9df70bdbf9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread scripts/slp_eval.sh Outdated
@marta-lokhova marta-lokhova force-pushed the properlyWaitForSorobanUpgrades branch from 9df70bd to cce48c3 Compare June 5, 2026 17:33
@marta-lokhova marta-lokhova merged commit 81eb6b3 into stellar:main Jun 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants