You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Cora README documentation from the dataset specifies that the column order is: cited-paper; citing-paper. However, at least one Jupyter notebook (namely cora-links-example.ipynb) assumes the column ordering: source; target.
Notwithstanding that this example assumes undirected edges, the constructed graph should accurately reflect the directed relationships inherent in the data.
This looks good to me. I point out that the directionality here is dependent upon the semantics of the link, the current links are a "cited_by" relationship, you are proposing to change this to a "cites" relationship. When we make this change it would be good to add a comment about the semantics of the link.
Note also that a lot of the demo notebooks use CORA with the same code, so we should change all of them.
geoffj-d61
changed the title
Reverse source--target node designations for code using Cora dataset
Fix source--target node designations for code using Cora dataset
Jul 9, 2019
@adocherty, agreed - I intend to review and fix all occurrences in the demos. Also, I'm not exactly changing to a "cites" relationship - this is already explicitly assumed in the notebooks; I am merely correcting the loaded directionality. While I am about it, I am also testing demos in python 3.6/3.7 and trying to understand them.
Description
The Cora README documentation from the dataset specifies that the column order is: cited-paper; citing-paper. However, at least one Jupyter notebook (namely cora-links-example.ipynb) assumes the column ordering:
source
;target
.Notwithstanding that this example assumes undirected edges, the constructed graph should accurately reflect the directed relationships inherent in the data.
How to reproduce (the error):
The relevant code snippet in the cora-links-example.ipynb notebook is:
Aim
To locate all code examples that load the Cora dataset, and ensure the loaded graphs utilise the correct target--source citation ordering.
The text was updated successfully, but these errors were encountered: