Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Keras with tf.keras #471

Closed
cdawei opened this issue Aug 8, 2019 · 1 comment
Closed

Replace Keras with tf.keras #471

cdawei opened this issue Aug 8, 2019 · 1 comment

Comments

@cdawei
Copy link
Contributor

cdawei commented Aug 8, 2019

Tensorflow has an implementation of the Keras API since v1.4.0 and tf.keras will be one of the mainly promoted interfaces in Tensorflow 2.0, which is supposed to be supported by stellargraph in the near future.

If we replace keras.xxx with tensorflow.keras.xxx, Keras could be safely dropped from the list of requirements. As a side bonus, there's no more waiting for Keras to officially support Python 3.7 :)

This can be seen as a preliminary work on #379, and I am happy to create pull requests if people think it is a worthwhile effort.

@youph
Copy link
Contributor

youph commented Aug 15, 2019

@cdawei this would be valuable, you're welcome to create a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants