--ignore-platform-reqs in PHPCS #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not ignoring platform requirements leads to workflows where an extension present in the test environment (e.g. `uopz`) and required by a development dependency (e.g. the `slope-it/clock-mock` one) will prevent the installation of Composer dependencies in the context of the PHPCS action.
borkweb
approved these changes
Aug 15, 2024
Member
|
I know this is in draft, but the justification sounds reasonable and the change looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ignoring platform requirements leads to workflows where an extension
present in the test environment (e.g.
uopz) and required by adevelopment dependency (e.g. the
slope-it/clock-mockone) will preventthe installation of Composer dependencies in the context of the PHPCS
action.
Example