fix(WebSocket): handle readyState properly

src/comms/WebSocketClient.ts

@@ -30,7 +30,12 @@ export default class WebSocketClient extends Client {
 
   // Overrides of `Client` methods
 
-  send (request: JsonRpcRequest) {
+  async send (request: JsonRpcRequest) {
+    if (this.socket.readyState !== WebSocket.OPEN) {
+      await new Promise(resolve => {
+        this.socket.onopen = () => resolve()
+      })
+    }
     this.socket.send(JSON.stringify(request))
   }
 }

tests/comms/WebSocketClientServer.test.ts

@@ -7,8 +7,7 @@ test('WebSockets', async () => {
   await server.start()
 
   const client = new WebSocketClient(`ws://${server.address}:${server.port}`)
-  await new Promise(resolve => setTimeout(resolve, 1000))
-
+
   const string = '{"type": "Person", "givenNames": ["John", "Paul"], "familyNames": ["Smith"]}'
   const object = JSON.parse(string)
   const thing = new Person(object)
@@ -23,5 +22,6 @@ test('WebSockets', async () => {
     expect(error.message).toEqual("Internal error: Unhandled import format: bar/baz")
   }
 
+  client.socket.close()
   await server.stop()
 })

tests/comms/browserTests.ts

@@ -2,9 +2,13 @@ import HttpClient from '../../src/comms/HttpClient'
 import WebSocketClient from '../../src/comms/WebSocketClient'
 import WebWorkerClient from '../../src/comms/WebWorkerClient'
 
+const thing = {type: 'Thing'}
+
 var httpClient = new HttpClient('http://127.0.0.1:2000')
+httpClient.execute(thing).then(console.log)
 
 var wsClient = new WebSocketClient('ws://127.0.0.1:2000')
+wsClient.execute(thing).then(console.log)
 
-var worker = new Worker('webWorkerServer.js')
-var wwClient = new WebWorkerClient(worker)
+var wwClient = new WebWorkerClient('/webWorkerServer.js')
+wwClient.execute(thing).then(console.log)