Skip to content

Commit

Permalink
Revert "GL/Context: Disable GLES3.2 on PowerVR Rogue"
Browse files Browse the repository at this point in the history
Broken driver is just broken. Not much I can do when I don't have one of
these phones and the shader compiler simply says "failure" without any
line information.
  • Loading branch information
stenzek committed Mar 9, 2021
1 parent 272daed commit 36ff345
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
6 changes: 0 additions & 6 deletions src/common/gl/context.cpp
Expand Up @@ -64,12 +64,6 @@ static void DisableBrokenExtensions(const char* gl_vendor, const char* gl_render
GLAD_GL_EXT_copy_image = 0;
GLAD_GL_OES_copy_image = 0;
}

if (std::strstr(gl_renderer, "PowerVR Rogue"))
{
Log_VerbosePrintf("PowerVR Rogue driver detected, disabling GLES3.2");
GLAD_GL_ES_VERSION_3_2 = 0;
}
}

Context::Context(const WindowInfo& wi) : m_wi(wi) {}
Expand Down
5 changes: 0 additions & 5 deletions src/core/shadergen.cpp
Expand Up @@ -36,7 +36,6 @@ void ShaderGen::DefineMacro(std::stringstream& ss, const char* name, bool enable
void ShaderGen::SetGLSLVersionString()
{
const char* glsl_version = reinterpret_cast<const char*>(glGetString(GL_SHADING_LANGUAGE_VERSION));
const char* gl_renderer = reinterpret_cast<const char*>(glGetString(GL_RENDERER));
const bool glsl_es = (m_render_api == HostDisplay::RenderAPI::OpenGLES);
Assert(glsl_version != nullptr);

Expand All @@ -59,10 +58,6 @@ void ShaderGen::SetGLSLVersionString()
major_version = 3;
minor_version = 20;
}

// Special cases - PowerVR's GLES 3.2 driver seems to choke on our shaders.
if (glsl_es && std::strstr(gl_renderer, "PowerVR Rogue") && major_version >= 3)
minor_version = std::min(minor_version, 10);
}
else
{
Expand Down

0 comments on commit 36ff345

Please sign in to comment.