Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
This would fix #3.
I tried to write unit tests as well as implement the function, but I couldn't figure out how the existing
So I'm afraid you'll have to write the unit tests and make sure my code is correct before merging it in. But it's a very straightforward change, and I could copy the logic from
Robin, the PR looks good! Could you add the
Done. I also reversed my decision about changing the
This should now be ready for you to merge and add the unit tests.