New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #157

Closed
elfring opened this Issue Oct 25, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@elfring

elfring commented Oct 25, 2013

I would like to point out that identifiers like "_MODBUS_H_" and "_MODBUS_TCP_H_" do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

@stephane stephane closed this in d06a3ee Nov 12, 2013

@stephane

This comment has been minimized.

Show comment
Hide comment
@stephane

stephane Nov 12, 2013

Owner

Thanks for the report, not sure to want to change constant names too...

Owner

stephane commented Nov 12, 2013

Thanks for the report, not sure to want to change constant names too...

@elfring

This comment has been minimized.

Show comment
Hide comment
@elfring

elfring Nov 12, 2013

Thanks for your improvement of the include guards.

I would prefer that the remaining affected identifiers will also become standard-compliant.

elfring commented Nov 12, 2013

Thanks for your improvement of the include guards.

I would prefer that the remaining affected identifiers will also become standard-compliant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment